You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by vo...@apache.org on 2024/08/15 03:47:18 UTC
(druid) 08/13: steps
This is an automated email from the ASF dual-hosted git repository.
vogievetsky pushed a commit to branch explore_source
in repository https://gitbox.apache.org/repos/asf/druid.git
commit 44028cde97d969d344844faad324254f4be8e8be
Author: Vadim Ogievetsky <va...@ogievetsky.com>
AuthorDate: Tue Aug 13 15:03:15 2024 -0700
steps
---
web-console/src/modules/bar-chart-module.tsx | 8 ++++++++
web-console/src/modules/grouping-table-module.scss | 3 ---
web-console/src/modules/grouping-table-module.tsx | 2 +-
web-console/src/modules/module-pane.scss | 1 +
web-console/src/modules/overall-module.scss | 2 --
web-console/src/modules/overall-module.tsx | 2 +-
web-console/src/modules/record-table-module.scss | 3 ---
web-console/src/modules/record-table-module.tsx | 2 +-
web-console/src/modules/timeline-module.scss | 2 --
web-console/src/modules/timeline-module.tsx | 2 +-
10 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/web-console/src/modules/bar-chart-module.tsx b/web-console/src/modules/bar-chart-module.tsx
index 47e00f36e06..a4bc26de555 100644
--- a/web-console/src/modules/bar-chart-module.tsx
+++ b/web-console/src/modules/bar-chart-module.tsx
@@ -134,6 +134,14 @@ ModuleRepository.registerModule<RecordTableParameterValues>({
return myChart;
}
+ useEffect(() => {
+ return () => {
+ const myChart = chartRef.current;
+ if (!myChart) return;
+ myChart.dispose();
+ };
+ }, []);
+
useEffect(() => {
const myChart = chartRef.current;
const data = dataState.data;
diff --git a/web-console/src/modules/grouping-table-module.scss b/web-console/src/modules/grouping-table-module.scss
index 65d79d15b87..a4fe582677f 100644
--- a/web-console/src/modules/grouping-table-module.scss
+++ b/web-console/src/modules/grouping-table-module.scss
@@ -17,9 +17,6 @@
*/
.grouping-table-module {
- width: 100%;
- height: 100%;
-
.generic-output-table {
height: 100%;
}
diff --git a/web-console/src/modules/grouping-table-module.tsx b/web-console/src/modules/grouping-table-module.tsx
index a1f68ba2718..9254361ddc9 100644
--- a/web-console/src/modules/grouping-table-module.tsx
+++ b/web-console/src/modules/grouping-table-module.tsx
@@ -264,7 +264,7 @@ ModuleRepository.registerModule<GroupingTableParameterValues>({
const resultData = resultState.getSomeData();
return (
- <div className="grouping-table-module">
+ <div className="grouping-table-module module">
{resultState.error ? (
<div>
<div>{resultState.getErrorMessage()}</div>
diff --git a/web-console/src/modules/module-pane.scss b/web-console/src/modules/module-pane.scss
index c926f6efa9b..3982e001268 100644
--- a/web-console/src/modules/module-pane.scss
+++ b/web-console/src/modules/module-pane.scss
@@ -23,6 +23,7 @@
@include card-like;
& > .module {
+ width: 100%;
height: 100%;
}
diff --git a/web-console/src/modules/overall-module.scss b/web-console/src/modules/overall-module.scss
index 47ad276fd37..7e97fccef30 100644
--- a/web-console/src/modules/overall-module.scss
+++ b/web-console/src/modules/overall-module.scss
@@ -17,8 +17,6 @@
*/
.overall-module {
- height: 100%;
- width: 100%;
display: grid;
grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
grid-gap: 10px;
diff --git a/web-console/src/modules/overall-module.tsx b/web-console/src/modules/overall-module.tsx
index 00c52f82f4e..d8145f08510 100644
--- a/web-console/src/modules/overall-module.tsx
+++ b/web-console/src/modules/overall-module.tsx
@@ -72,7 +72,7 @@ ModuleRepository.registerModule<OverallParameterValues>({
const row = valuesState.data?.toObjectArray()?.[0];
return (
- <div className="overall-module">
+ <div className="overall-module module">
{metrics.map((metric, i) => (
<div className="metric-entry" key={i}>
<div className="metric-name">{metric.name}</div>
diff --git a/web-console/src/modules/record-table-module.scss b/web-console/src/modules/record-table-module.scss
index e3ebe33fdc7..e99902c43fe 100644
--- a/web-console/src/modules/record-table-module.scss
+++ b/web-console/src/modules/record-table-module.scss
@@ -17,9 +17,6 @@
*/
.record-table-module {
- width: 100%;
- height: 100%;
-
.generic-output-table {
height: 100%;
}
diff --git a/web-console/src/modules/record-table-module.tsx b/web-console/src/modules/record-table-module.tsx
index 2efdd87fc1f..1eeda2ae7f1 100644
--- a/web-console/src/modules/record-table-module.tsx
+++ b/web-console/src/modules/record-table-module.tsx
@@ -79,7 +79,7 @@ ModuleRepository.registerModule<RecordTableParameterValues>({
const resultData = resultState.getSomeData();
return (
- <div className="record-table-module">
+ <div className="record-table-module module">
{resultState.error ? (
<div>
<div>{resultState.getErrorMessage()}</div>
diff --git a/web-console/src/modules/timeline-module.scss b/web-console/src/modules/timeline-module.scss
index 6279103571c..3211f458ce0 100644
--- a/web-console/src/modules/timeline-module.scss
+++ b/web-console/src/modules/timeline-module.scss
@@ -19,8 +19,6 @@
$circle-radius: 5px;
.timeline-module {
- width: 100%;
- height: 100%;
position: relative;
.timeline-line {
diff --git a/web-console/src/modules/timeline-module.tsx b/web-console/src/modules/timeline-module.tsx
index 8cc6fe9ee99..93b819f2fd7 100644
--- a/web-console/src/modules/timeline-module.tsx
+++ b/web-console/src/modules/timeline-module.tsx
@@ -135,7 +135,7 @@ ModuleRepository.registerModule<TimelineParameterValues>({
}
return (
- <div className="timeline-module">
+ <div className="timeline-module module">
{resultState.error ? (
<div>
<div>{resultState.getErrorMessage()}</div>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org