[GitHub] [phoenix] yanxinyi commented on a change in pull request #1402: PHOENIX-6662 Failed to delete when PK with DESC with IN clause

[GitBox <gi...@apache.org>]

yanxinyi commented on a change in pull request #1402:
URL: https://github.com/apache/phoenix/pull/1402#discussion_r826201977



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java
##########
@@ -2197,10 +2203,11 @@ public SortOrder getSortOrder() {
                     // for the non-equality cases return actual sort order
                     //This work around should work
                     // but a more general approach can be taken.
-                    if(rvcElementOp == CompareOp.EQUAL ||
-                            rvcElementOp == CompareOp.NOT_EQUAL){
-                        return SortOrder.ASC;
-                    }
+                    //This optimization causes PHOENIX-6662 (when desc pk used with in clause)

Review comment:
       nit: maybe remove instead of keeping it? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org