You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/20 08:21:46 UTC

[GitHub] [spark] beliefer commented on a diff in pull request #37937: [SPARK-40491][SQL] Expose a jdbcRDD function in SparkContext

beliefer commented on code in PR #37937:
URL: https://github.com/apache/spark/pull/37937#discussion_r975035181


##########
core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala:
##########
@@ -32,7 +32,6 @@ private[spark] class JdbcPartition(idx: Int, val lower: Long, val upper: Long) e
   override def index: Int = idx
 }
 
-// TODO: Expose a jdbcRDD function in SparkContext and mark this as semi-private

Review Comment:
   So, could we remove this TODO comment ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org