You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Robert Middleton (Jira)" <lo...@logging.apache.org> on 2022/08/18 23:37:00 UTC
[jira] [Commented] (LOGCXX-558) Prevent MSVC compilation warnings "needs to have dll-interface"
[ https://issues.apache.org/jira/browse/LOGCXX-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581573#comment-17581573 ]
Robert Middleton commented on LOGCXX-558:
-----------------------------------------
Should we instead have the private data have a dll interface? I'm thinking of a (potential) situation where you would want to extend a class, especially the AppenderSkeleton class.
> Prevent MSVC compilation warnings "needs to have dll-interface"
> ---------------------------------------------------------------
>
> Key: LOGCXX-558
> URL: https://issues.apache.org/jira/browse/LOGCXX-558
> Project: Log4cxx
> Issue Type: Improvement
> Reporter: Stephen Webb
> Priority: Minor
>
> The private data of classes do not prevent Microsoft compiler warning messages.
>
> As the private data is inaccessible by client application it should be safe to ignore the warning. This can be done using a macro
> ```
> #if _WIN32
> #define LOG4CXX_DECLARE_PRIVATE_STRUCT(T, V) \
> __pragma( warning( push ) ) \
> __pragma( warning( disable : 4251 ) ) \
> struct T; std::unique_ptr<T> V; \
> __pragma( warning( pop ) )
> #else
> #define LOG4CXX_DECLARE_PRIVATE_STRUCT(T, V) struct T; std::unique_ptr<T> V;
> #endif /* WIN32 */
> ```
--
This message was sent by Atlassian Jira
(v8.20.10#820010)