[GitHub] [pinot] walterddr commented on a change in pull request #7883: Upgrade kafka to 2.8.1

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #7883:
URL: https://github.com/apache/pinot/pull/7883#discussion_r767940608



##########
File path: pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark/pom.xml
##########
@@ -36,6 +36,7 @@
   <properties>
     <pinot.root>${basedir}/../../..</pinot.root>
     <phase.prop>package</phase.prop>
+    <scala.binary.version>2.11</scala.binary.version>

Review comment:
       this is already declaired in main pom.xml? or were you also meant to change the main pom.xml scala.binary.version to 2.13 as well?

##########
File path: pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/pom.xml
##########
@@ -35,7 +35,7 @@
   <url>https://pinot.apache.org/</url>
   <properties>
     <pinot.root>${basedir}/../../..</pinot.root>
-    <kafka.lib.version>2.0.0</kafka.lib.version>
+    <kafka.lib.version>2.8.1</kafka.lib.version>

Review comment:
       i dunno if it is worthy to change the artifactId to `pinot-kafka-2.8` or `pinot-kafka-2.x`, but it might be confusing going forward.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org