You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/01/12 21:49:29 UTC

[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on a change in pull request #349: [YUNIKORN-937] Update eventrecorder usage to new K8S API

craigcondit commented on a change in pull request #349:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/349#discussion_r783468798



##########
File path: pkg/cache/application.go
##########
@@ -422,7 +422,7 @@ func (app *Application) scheduleTasks(taskScheduleCondition func(t *Task) bool)
 					log.Logger().Warn("init task failed", zap.Error(err))
 				}
 			} else {
-				events.GetRecorder().Event(task.GetTaskPod(), v1.EventTypeWarning, "FailedScheduling", err.Error())
+				events.GetRecorder().Eventf(task.GetTaskPod(), nil, v1.EventTypeWarning, "FailedScheduling", "FailedScheduling", err.Error())

Review comment:
       This looks fine to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org