You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/06/11 21:41:48 UTC
Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Greg Mann.
Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935
Repository: mesos
Description
-------
This test verifies that the allocator honors the
`min_allocatable_resources` flag and only offers resources
that are more than at least one of the specified resources quantity.
Diffs
-----
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
Diff: https://reviews.apache.org/r/67517/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review205130
-----------------------------------------------------------
PASS: Mesos patch 67517 was successfully built and tested.
Reviews applied: `['67510', '67516', '67513', '67517']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67517
- Mesos Reviewbot Windows
On June 20, 2018, 10:22 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 10:22 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review205139
-----------------------------------------------------------
src/tests/master_allocator_tests.cpp
Lines 86 (patched)
<https://reviews.apache.org/r/67517/#comment288100>
This isn't necessary. I'll fix while committing.
- Greg Mann
On June 20, 2018, 10:22 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 10:22 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/
-----------------------------------------------------------
(Updated June 20, 2018, 3:22 p.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935
Repository: mesos
Description
-------
This test verifies that the allocator honors the
`min_allocatable_resources` flag and only offers resources
that are more than at least one of the specified resources quantity.
Diffs (updated)
-----
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
Diff: https://reviews.apache.org/r/67517/diff/5/
Changes: https://reviews.apache.org/r/67517/diff/4-5/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review205123
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_allocator_tests.cpp
Lines 1281-1283 (patched)
<https://reviews.apache.org/r/67517/#comment288092>
Nit: could you make the ordering of these two lines the same here as it is down below for the allocatable agents?
src/tests/master_allocator_tests.cpp
Lines 1333 (patched)
<https://reviews.apache.org/r/67517/#comment288093>
Nit: `offers->size()`
- Greg Mann
On June 20, 2018, 8:40 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 8:40 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/
-----------------------------------------------------------
(Updated June 20, 2018, 1:40 p.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Changes
-------
Updated tests to pause clock.
Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935
Repository: mesos
Description
-------
This test verifies that the allocator honors the
`min_allocatable_resources` flag and only offers resources
that are more than at least one of the specified resources quantity.
Diffs (updated)
-----
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
Diff: https://reviews.apache.org/r/67517/diff/4/
Changes: https://reviews.apache.org/r/67517/diff/3-4/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review204886
-----------------------------------------------------------
PASS: Mesos patch 67517 was successfully built and tested.
Reviews applied: `['67510', '67516', '67513', '67517']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67517
- Mesos Reviewbot Windows
On June 15, 2018, 3:05 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 3:05 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On June 19, 2018, 4:08 p.m., Greg Mann wrote:
> > src/tests/master_allocator_tests.cpp
> > Lines 1270 (patched)
> > <https://reviews.apache.org/r/67517/diff/2/?file=2041134#file2041134line1270>
> >
> > Is there a reason you don't do
> >
> > ```
> > flags.resources = resourcesString;
> > ```
> >
> > ??
Ah, I think I copied from other places. Updated.
> On June 19, 2018, 4:08 p.m., Greg Mann wrote:
> > src/tests/master_allocator_tests.cpp
> > Lines 1279-1281 (patched)
> > <https://reviews.apache.org/r/67517/diff/2/?file=2041134#file2041134line1279>
> >
> > Could you leave a comment explaining why this is necessary?
> >
> > Is there a reason we can't pause the clock for the entire duration of the test?
Done.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review205016
-----------------------------------------------------------
On June 15, 2018, 3:05 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 3:05 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review205016
-----------------------------------------------------------
src/tests/master_allocator_tests.cpp
Lines 1241 (patched)
<https://reviews.apache.org/r/67517/#comment287873>
s/resources quantity/resource quantities/
src/tests/master_allocator_tests.cpp
Lines 1270 (patched)
<https://reviews.apache.org/r/67517/#comment287916>
Is there a reason you don't do
```
flags.resources = resourcesString;
```
??
src/tests/master_allocator_tests.cpp
Lines 1279-1281 (patched)
<https://reviews.apache.org/r/67517/#comment287917>
Could you leave a comment explaining why this is necessary?
Is there a reason we can't pause the clock for the entire duration of the test?
src/tests/master_allocator_tests.cpp
Lines 1330 (patched)
<https://reviews.apache.org/r/67517/#comment287919>
s/non-allocable/non-allocatable/
- Greg Mann
On June 15, 2018, 10:05 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 10:05 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review204899
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67510, 67516, 67513, 67517]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 15, 2018, 3:05 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 3:05 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review205115
-----------------------------------------------------------
PASS: Mesos patch 67517 was successfully built and tested.
Reviews applied: `['67510', '67516', '67513', '67517']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67517
- Mesos Reviewbot Windows
On June 16, 2018, 12:05 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 16, 2018, 12:05 a.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/
-----------------------------------------------------------
(Updated June 15, 2018, 3:05 p.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Changes
-------
Removed JSON input test.
Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935
Repository: mesos
Description
-------
This test verifies that the allocator honors the
`min_allocatable_resources` flag and only offers resources
that are more than at least one of the specified resources quantity.
Diffs (updated)
-----
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
Diff: https://reviews.apache.org/r/67517/diff/2/
Changes: https://reviews.apache.org/r/67517/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67517: Added a test to verify
`min_allocatable_resources` flag.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67517/#review204576
-----------------------------------------------------------
PASS: Mesos patch 67517 was successfully built and tested.
Reviews applied: `['67510', '67516', '67513', '67517']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67517
- Mesos Reviewbot Windows
On June 11, 2018, 2:41 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67517/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 2:41 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that the allocator honors the
> `min_allocatable_resources` flag and only offers resources
> that are more than at least one of the specified resources quantity.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
>
>
> Diff: https://reviews.apache.org/r/67517/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>