[GitHub] [carbondata] jackylk commented on a change in pull request #3614: [CARBONDATA-3693] Separate Index command from DataMap command

[GitBox <gi...@apache.org>]

jackylk commented on a change in pull request #3614: [CARBONDATA-3693] Separate Index command from DataMap command
URL: https://github.com/apache/carbondata/pull/3614#discussion_r385609150
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ##########
 @@ -460,10 +460,9 @@ private CarbonCommonConstants() {
   public static final String LOCAL_DICTIONARY_EXCLUDE = "local_dictionary_exclude";
 
   /**
-   * DMPROPERTY for Index DataMap, like lucene, bloomfilter DataMap,
-   * to indicate a list of column name to be indexed
+   * Internal property to store for index column names
    */
-  public static final String INDEX_COLUMNS = "INDEX_COLUMNS";
+  public static final String INDEX_COLUMNS = "_INDEX_COLUMNS";
 
 Review comment:
   This is a temporary change,  index metadata should also unified using main table's table property. This will be done in another PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services