[GitHub] [activemq-nms-amqp] Jefwillems commented on a diff in pull request #86: allow acktype modified_failed

["Jefwillems (via GitHub)" <gi...@apache.org>]

Jefwillems commented on code in PR #86:
URL: https://github.com/apache/activemq-nms-amqp/pull/86#discussion_r1133531798


##########
src/NMS.AMQP/Apache-NMS-AMQP.csproj:
##########
@@ -32,7 +32,7 @@ with the License.  You may obtain a copy of the License at
 
     <PropertyGroup>
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-        <PackageId>Apache.NMS.AMQP</PackageId>
+        <PackageId>Jef.Apache.NMS.AMQP</PackageId>

Review Comment:
   didn't realize this would show up here. Done as a temporary fix for a probleem w're having 



##########
.github/GitVersion.yml:
##########
@@ -0,0 +1,6 @@
+assembly-versioning-scheme: MajorMinorPatch

Review Comment:
   didn't realize this would show up here. Done as a temporary fix for a probleem w're having 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org