You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/04 15:57:14 UTC
[GitHub] [arrow] pitrou opened a new pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
pitrou opened a new pull request #10245:
URL: https://github.com/apache/arrow/pull/10245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832265767
Benchmark runs are scheduled for baseline = 2bd8dc2d4dcbc905d0277e3b232c8129762cf888 and contender = 3955397de10576af6bf7ac4b82a59d4bed4ad7df. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:33.33%] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/fa61c04485684f04adfddbd700309044...35b6aa4849c248668c124bbc55569f5b/)
[Finished :arrow_down:100.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6ae3dbd47e5f4352988ea53a3969f52c...79510af5ca60463e9cc96b104b26cfbd/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f03c47e09697421a9422239c5c5ce352...01bed71a8780496d90b571cbfa73075a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3d58ac63b01f4d2bb9b223ab5e4f0db8...b017f6570dd1405490fe6a78679a3535/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832052957
Benchmark runs are scheduled for baseline = cb29537de79da0d6693e8d44ef0f57434d6d38da and contender = 11a6c3f7fe9066b7e5e6bcf85f8b373962441a75. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:66.67% :arrow_up:0.0%] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/5a5ab4fde43d4e4e99d91dab04b66234...543d5e46bdc9482eaa8eec8692aee378/)
[Finished :arrow_down:33.33% :arrow_up:33.33%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c2bfd0133df446cdbbbf984180d7770d...39c88a9023404a64b4f1870170902148/)
[Finished :arrow_down:1.45% :arrow_up:0.72%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24ec9f992c19466a9df726eee8caa2b2...1ddeda22df7b48ce982e20926085c656/)
[Finished :arrow_down:1.91% :arrow_up:2.73%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b5cdc36b7e5b43afab75ed86de55e4d7...46c3105042714c6aab8c9f672d381e56/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-837512426
I'm not sure that it causes a problem with our use cases without try.
How about adding an option for `-Bsymbolic-functions` like `ARROW_USE_LD_GOLD` instead of enabling this unconditionally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832052957
Benchmark runs are scheduled for baseline = cb29537de79da0d6693e8d44ef0f57434d6d38da and contender = 11a6c3f7fe9066b7e5e6bcf85f8b373962441a75. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/5a5ab4fde43d4e4e99d91dab04b66234...543d5e46bdc9482eaa8eec8692aee378/)
[Finished :arrow_down:33.33% :arrow_up:33.33%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c2bfd0133df446cdbbbf984180d7770d...39c88a9023404a64b4f1870170902148/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24ec9f992c19466a9df726eee8caa2b2...1ddeda22df7b48ce982e20926085c656/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b5cdc36b7e5b43afab75ed86de55e4d7...46c3105042714c6aab8c9f672d381e56/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832052957
Benchmark runs are scheduled for baseline = cb29537de79da0d6693e8d44ef0f57434d6d38da and contender = 11a6c3f7fe9066b7e5e6bcf85f8b373962441a75. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:66.67% :arrow_up:0.0%] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/5a5ab4fde43d4e4e99d91dab04b66234...543d5e46bdc9482eaa8eec8692aee378/)
[Finished :arrow_down:33.33% :arrow_up:33.33%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c2bfd0133df446cdbbbf984180d7770d...39c88a9023404a64b4f1870170902148/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24ec9f992c19466a9df726eee8caa2b2...1ddeda22df7b48ce982e20926085c656/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b5cdc36b7e5b43afab75ed86de55e4d7...46c3105042714c6aab8c9f672d381e56/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832265423
There were some significant improvements in the C++ micro-benchmark numbers but I wonder it's just because of instability. Will try another run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832265767
Benchmark runs are scheduled for baseline = 2bd8dc2d4dcbc905d0277e3b232c8129762cf888 and contender = 3955397de10576af6bf7ac4b82a59d4bed4ad7df. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/fa61c04485684f04adfddbd700309044...35b6aa4849c248668c124bbc55569f5b/)
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6ae3dbd47e5f4352988ea53a3969f52c...79510af5ca60463e9cc96b104b26cfbd/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f03c47e09697421a9422239c5c5ce352...01bed71a8780496d90b571cbfa73075a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3d58ac63b01f4d2bb9b223ab5e4f0db8...b017f6570dd1405490fe6a78679a3535/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832052957
Benchmark runs are scheduled for baseline = cb29537de79da0d6693e8d44ef0f57434d6d38da and contender = 11a6c3f7fe9066b7e5e6bcf85f8b373962441a75. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/5a5ab4fde43d4e4e99d91dab04b66234...543d5e46bdc9482eaa8eec8692aee378/)
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c2bfd0133df446cdbbbf984180d7770d...39c88a9023404a64b4f1870170902148/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24ec9f992c19466a9df726eee8caa2b2...1ddeda22df7b48ce982e20926085c656/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b5cdc36b7e5b43afab75ed86de55e4d7...46c3105042714c6aab8c9f672d381e56/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832052835
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832052950
https://issues.apache.org/jira/browse/ARROW-12627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832265767
Benchmark runs are scheduled for baseline = 2bd8dc2d4dcbc905d0277e3b232c8129762cf888 and contender = 3955397de10576af6bf7ac4b82a59d4bed4ad7df. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/fa61c04485684f04adfddbd700309044...35b6aa4849c248668c124bbc55569f5b/)
[Finished :arrow_down:100.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6ae3dbd47e5f4352988ea53a3969f52c...79510af5ca60463e9cc96b104b26cfbd/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f03c47e09697421a9422239c5c5ce352...01bed71a8780496d90b571cbfa73075a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3d58ac63b01f4d2bb9b223ab5e4f0db8...b017f6570dd1405490fe6a78679a3535/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832265616
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-836704278
This seems to decrease code size by 3-5%. Benchmark results seem unconclusive. @kou @xhochy What do you think about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832052957
Benchmark runs are scheduled for baseline = cb29537de79da0d6693e8d44ef0f57434d6d38da and contender = 11a6c3f7fe9066b7e5e6bcf85f8b373962441a75. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:66.67% :arrow_up:0.0%] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/5a5ab4fde43d4e4e99d91dab04b66234...543d5e46bdc9482eaa8eec8692aee378/)
[Finished :arrow_down:33.33% :arrow_up:33.33%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c2bfd0133df446cdbbbf984180d7770d...39c88a9023404a64b4f1870170902148/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24ec9f992c19466a9df726eee8caa2b2...1ddeda22df7b48ce982e20926085c656/)
[Finished :arrow_down:1.91% :arrow_up:2.73%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b5cdc36b7e5b43afab75ed86de55e4d7...46c3105042714c6aab8c9f672d381e56/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832265767
Benchmark runs are scheduled for baseline = 2bd8dc2d4dcbc905d0277e3b232c8129762cf888 and contender = 3955397de10576af6bf7ac4b82a59d4bed4ad7df. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:33.33%] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/fa61c04485684f04adfddbd700309044...35b6aa4849c248668c124bbc55569f5b/)
[Finished :arrow_down:100.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6ae3dbd47e5f4352988ea53a3969f52c...79510af5ca60463e9cc96b104b26cfbd/)
[Finished :arrow_down:0.72% :arrow_up:0.72%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f03c47e09697421a9422239c5c5ce352...01bed71a8780496d90b571cbfa73075a/)
[Finished :arrow_down:1.8% :arrow_up:2.37%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3d58ac63b01f4d2bb9b223ab5e4f0db8...b017f6570dd1405490fe6a78679a3535/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-838059262
As far as I understand, it has a similar effect to `-fno-semantic-interposition`: functions inside the library don't go through shared symbol resolution (so you cannot use `LD_PRELOAD` etc.). According to https://lore.kernel.org/lkml/20210501235549.vugtjeb7dmd5xell@google.com/ , it's compatible with LLVM and CLang (which are big C++ projects).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10245: ARROW-12627: [C++] Link shared libraries with -Bsymbolic-functions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10245:
URL: https://github.com/apache/arrow/pull/10245#issuecomment-832265767
Benchmark runs are scheduled for baseline = 2bd8dc2d4dcbc905d0277e3b232c8129762cf888 and contender = 3955397de10576af6bf7ac4b82a59d4bed4ad7df. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:33.33%] [ec2-t3-large-us-east-2](https://conbench.ursa.dev/compare/runs/fa61c04485684f04adfddbd700309044...35b6aa4849c248668c124bbc55569f5b/)
[Finished :arrow_down:100.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6ae3dbd47e5f4352988ea53a3969f52c...79510af5ca60463e9cc96b104b26cfbd/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f03c47e09697421a9422239c5c5ce352...01bed71a8780496d90b571cbfa73075a/)
[Finished :arrow_down:1.8% :arrow_up:2.37%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3d58ac63b01f4d2bb9b223ab5e4f0db8...b017f6570dd1405490fe6a78679a3535/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org