You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Jeremy Boynes <jb...@apache.org> on 2006/08/12 02:55:43 UTC

[VOTE] indent on case

In our code guidelines (or at least the IDE setup files), case is not  
indented
     switch (i) {
     case 1:
         break;

but the checkstyle profile is looking for a 4 character indent:
     switch (i) {
         case 1:
             break;

which do we want?

[ ] No indent
[ ] Indent 4 characters

--
Jeremy

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: [VOTE] indent on case

Posted by Jeremy Boynes <jb...@apache.org>.
My vote
On Aug 11, 2006, at 5:55 PM, Jeremy Boynes wrote:

> In our code guidelines (or at least the IDE setup files), case is  
> not indented
>     switch (i) {
>     case 1:
>         break;
>
> [X] No indent
> [ ] Indent 4 characters

--
Jeremy


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: [VOTE] indent on case

Posted by kelvin goodson <ke...@gmail.com>.
i'm in the indent camp

On 12/08/06, Meeraj Kunnumpurath <m....@hotmail.co.uk> wrote:
>
> I like indent on case in line with the rest of the indenting policy.
>
>
> >From: Jim Marino <jm...@myromatours.com>
> >Reply-To: tuscany-dev@ws.apache.org
> >To: tuscany-dev@ws.apache.org
> >Subject: Re: [VOTE] indent on case
> >Date: Fri, 11 Aug 2006 18:31:58 -0700
> >
> >I'm note sure this requires a vote but I prefer indent 4.
> >
> >Jim
> >
> >
> >On Aug 11, 2006, at 5:55 PM, Jeremy Boynes wrote:
> >
> >>In our code guidelines (or at least the IDE setup files), case is  not
> >>indented
> >>     switch (i) {
> >>     case 1:
> >>         break;
> >>
> >>but the checkstyle profile is looking for a 4 character indent:
> >>     switch (i) {
> >>         case 1:
> >>             break;
> >>
> >>which do we want?
> >>
> >>[ ] No indent
> >>[ ] Indent 4 characters
> >>
> >>--
> >>Jeremy
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> >>For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >>
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> >For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
>
> _________________________________________________________________
> Be the first to hear what's new at MSN - sign up to our free newsletters!
> http://www.msn.co.uk/newsletters
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>


-- 
Best Regards
Kelvin Goodson

Re: [VOTE] indent on case

Posted by Jeremy Boynes <jb...@apache.org>.
The other elements would go at the level of the "break" - indent 4 or  
indent 8 respectively.

That's actually why I prefer the "no-indent" case as it puts the  
other elements at the same indent as if you were using an "if" block  
in rather than an additional 4 characters in.

--
Jeremy

On Aug 11, 2006, at 6:46 PM, Yang ZHONG wrote:

> "switch" clause may have statements other than "case", and people  
> normally
> indent sub elements...
>
>
> -- 
>
> Yang ZHONG


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: [VOTE] indent on case

Posted by Yang ZHONG <le...@gmail.com>.
"switch" clause may have statements other than "case", and people normally
indent sub elements...


-- 

Yang ZHONG

Re: [VOTE] indent on case

Posted by Meeraj Kunnumpurath <m....@hotmail.co.uk>.
I like indent on case in line with the rest of the indenting policy.


>From: Jim Marino <jm...@myromatours.com>
>Reply-To: tuscany-dev@ws.apache.org
>To: tuscany-dev@ws.apache.org
>Subject: Re: [VOTE] indent on case
>Date: Fri, 11 Aug 2006 18:31:58 -0700
>
>I'm note sure this requires a vote but I prefer indent 4.
>
>Jim
>
>
>On Aug 11, 2006, at 5:55 PM, Jeremy Boynes wrote:
>
>>In our code guidelines (or at least the IDE setup files), case is  not 
>>indented
>>     switch (i) {
>>     case 1:
>>         break;
>>
>>but the checkstyle profile is looking for a 4 character indent:
>>     switch (i) {
>>         case 1:
>>             break;
>>
>>which do we want?
>>
>>[ ] No indent
>>[ ] Indent 4 characters
>>
>>--
>>Jeremy
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>>For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>

_________________________________________________________________
Be the first to hear what's new at MSN - sign up to our free newsletters! 
http://www.msn.co.uk/newsletters


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: [VOTE] indent on case

Posted by Jim Marino <jm...@myromatours.com>.
I'm note sure this requires a vote but I prefer indent 4.

Jim


On Aug 11, 2006, at 5:55 PM, Jeremy Boynes wrote:

> In our code guidelines (or at least the IDE setup files), case is  
> not indented
>     switch (i) {
>     case 1:
>         break;
>
> but the checkstyle profile is looking for a 4 character indent:
>     switch (i) {
>         case 1:
>             break;
>
> which do we want?
>
> [ ] No indent
> [ ] Indent 4 characters
>
> --
> Jeremy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org