You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/28 12:55:54 UTC
[GitHub] [superset] simchaNielsen opened a new pull request #12199: WIP: Add defaultValue for Native filters
simchaNielsen opened a new pull request #12199:
URL: https://github.com/apache/superset/pull/12199
### SUMMARY
Add support for defaultValue in Native filters Config Modal per filter type
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/56388545/103091049-92fb9080-45fb-11eb-891e-69cd2532f3e6.mov
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: WIP: Add defaultValue for Native filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (33400b6) into [master](https://codecov.io/gh/apache/superset/commit/49e6e420da517e7348599a53722afc8ab2231559?el=desc) (49e6e42) will **decrease** coverage by `3.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 66.99% 63.70% -3.30%
==========================================
Files 1022 488 -534
Lines 50049 30142 -19907
Branches 4914 0 -4914
==========================================
- Hits 33532 19201 -14331
+ Misses 16393 10941 -5452
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.70% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <0.00%> (-8.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.98% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.05% <0.00%> (-0.02%)` | :arrow_down: |
| ... and [530 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [49e6e42...33400b6](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (50f812c) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
+ Coverage 63.23% 63.39% +0.15%
==========================================
Files 1021 489 -532
Lines 50145 30197 -19948
Branches 5204 0 -5204
==========================================
- Hits 31708 19142 -12566
+ Misses 18222 11055 -7167
+ Partials 215 0 -215
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.39% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [539 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...10529e9](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (51818e6) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **decrease** coverage by `0.43%`.
> The diff coverage is `41.78%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 63.23% 62.79% -0.44%
==========================================
Files 1021 1022 +1
Lines 50145 50228 +83
Branches 5204 5246 +42
==========================================
- Hits 31708 31540 -168
- Misses 18222 18474 +252
+ Partials 215 214 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.90% <41.78%> (-0.03%)` | :arrow_down: |
| python | `63.38% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <0.00%> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (ø)` | |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `34.78% <ø> (ø)` | |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <25.00%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `50.70% <27.77%> (+2.62%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `59.09% <36.73%> (-6.95%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `70.88% <56.81%> (-18.01%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...51818e6](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12199: WIP: Add defaultValue for Native filters
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (33400b6) into [master](https://codecov.io/gh/apache/superset/commit/49e6e420da517e7348599a53722afc8ab2231559?el=desc) (49e6e42) will **decrease** coverage by `3.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 66.99% 63.70% -3.30%
==========================================
Files 1022 488 -534
Lines 50049 30142 -19907
Branches 4914 0 -4914
==========================================
- Hits 33532 19201 -14331
+ Misses 16393 10941 -5452
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.70% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <0.00%> (-8.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.98% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.05% <0.00%> (-0.02%)` | :arrow_down: |
| ... and [530 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [49e6e42...33400b6](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769473311
also from the UX standpoint, filter values select probably more than most of the time. @simcha90 @agatapst I think we should check allow multiple-selections box checked by default in the modal, for both default value setting and filter value select
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on a change in pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
simcha90 commented on a change in pull request #12199:
URL: https://github.com/apache/superset/pull/12199#discussion_r568338774
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -78,15 +82,15 @@ export type FilterType = 'text' | 'date';
export interface Filter {
allowsMultipleValues: boolean;
cascadeParentIds: string[];
- defaultValue: string | null;
- currentValue?: (string | number | boolean)[] | null;
+ defaultValue: any;
+ currentValue?: any;
Review comment:
it's value that we are passing to the native filter, so it should be `currentValue` together with default value and not `currentState`
I think may be we need to discuss in future if we want to render some things like `Allow multiple selection` checkbox inside of native filter chart so it should be really changed to currentState but for now all filters working only with `currentValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (51818e6) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
+ Coverage 63.23% 63.38% +0.15%
==========================================
Files 1021 489 -532
Lines 50145 30180 -19965
Branches 5204 0 -5204
==========================================
- Hits 31708 19129 -12579
+ Misses 18222 11051 -7171
+ Partials 215 0 -215
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.38% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.55% <0.00%> (-5.47%)` | :arrow_down: |
| ... and [546 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...51818e6](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (b91b3f1) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **decrease** coverage by `0.22%`.
> The diff coverage is `42.17%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 63.23% 63.00% -0.23%
==========================================
Files 1021 1022 +1
Lines 50145 50244 +99
Branches 5204 5246 +42
==========================================
- Hits 31708 31657 -51
- Misses 18222 18373 +151
+ Partials 215 214 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.90% <42.17%> (-0.03%)` | :arrow_down: |
| python | `63.73% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <0.00%> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (ø)` | |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `34.78% <ø> (ø)` | |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <25.00%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.04% <31.57%> (+2.97%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `59.09% <36.73%> (-6.95%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `70.88% <56.81%> (-18.01%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...b91b3f1](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12199: WIP: Add defaultValue for Native filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-768878208
closes https://github.com/apache/superset/issues/12713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simchaNielsen commented on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769213320
@junlincc @villebro I synced this PR with master and updated it, so I think it's ready to review, if you think that this PR relevant for settings defaultValue in native filters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simchaNielsen closed pull request #12199: WIP: Add defaultValue for Native filters
Posted by GitBox <gi...@apache.org>.
simchaNielsen closed pull request #12199:
URL: https://github.com/apache/superset/pull/12199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: WIP: Add defaultValue for Native filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (33400b6) into [master](https://codecov.io/gh/apache/superset/commit/49e6e420da517e7348599a53722afc8ab2231559?el=desc) (49e6e42) will **decrease** coverage by `3.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 66.99% 63.73% -3.27%
==========================================
Files 1022 488 -534
Lines 50049 30142 -19907
Branches 4914 0 -4914
==========================================
- Hits 33532 19212 -14320
+ Misses 16393 10930 -5463
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.73% <ø> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <0.00%> (-8.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.05% <0.00%> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.58% <0.00%> (ø)` | |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [49e6e42...33400b6](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simchaNielsen edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
simchaNielsen edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769213320
@agatapst @junlincc @villebro I synced this PR with master and updated it, so I think it's ready to review, if you think that this PR relevant for settings defaultValue in native filters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12199:
URL: https://github.com/apache/superset/pull/12199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769473311
also from the UX standpoint, filter values select probably more than most of the time. @simcha90 @agatapst I think we should check allow multiple-selections box checked by default in the modal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (51818e6) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **increase** coverage by `3.74%`.
> The diff coverage is `44.52%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
+ Coverage 63.23% 66.97% +3.74%
==========================================
Files 1021 1022 +1
Lines 50145 50264 +119
Branches 5204 5246 +42
==========================================
+ Hits 31708 33664 +1956
+ Misses 18222 16466 -1756
+ Partials 215 134 -81
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.88% <42.55%> (?)` | |
| javascript | `61.90% <41.78%> (-0.03%)` | :arrow_down: |
| python | `63.98% <ø> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `39.13% <0.00%> (+4.34%)` | :arrow_up: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.89% <ø> (+0.15%)` | :arrow_up: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `60.86% <ø> (+26.08%)` | :arrow_up: |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (+100.00%)` | :arrow_up: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <25.00%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.74% <27.77%> (+3.67%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `59.09% <36.73%> (-6.95%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `83.60% <64.28%> (-2.51%)` | :arrow_down: |
| ... and [199 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...b91b3f1](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on a change in pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
simcha90 commented on a change in pull request #12199:
URL: https://github.com/apache/superset/pull/12199#discussion_r568338774
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -78,15 +82,15 @@ export type FilterType = 'text' | 'date';
export interface Filter {
allowsMultipleValues: boolean;
cascadeParentIds: string[];
- defaultValue: string | null;
- currentValue?: (string | number | boolean)[] | null;
+ defaultValue: any;
+ currentValue?: any;
Review comment:
it's value that we are passing to the native filter, so it should be `currentValue` together with default value and not `currentState`
I think may be we need to discuss in future if we want to render some things like `Allow multiple selection` checkbox inside of native filter chart so it should be really changed to currentState but for now all filters working only with `currentValue`
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -29,12 +29,13 @@ export type AntCallback = (value1?: any, value2?: any) => void;
interface NativeFiltersFormItem {
scope: Scope;
name: string;
+ filterType: FilterType;
dataset: {
value: number;
label: string;
};
column: string;
- defaultValue: string;
+ defaultValue: any;
Review comment:
explained in bottom comment 👇 :)
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -78,15 +82,15 @@ export type FilterType = 'text' | 'date';
export interface Filter {
allowsMultipleValues: boolean;
cascadeParentIds: string[];
- defaultValue: string | null;
- currentValue?: (string | number | boolean)[] | null;
+ defaultValue: any;
+ currentValue?: any;
Review comment:
it's value that we are passing to the native filter, so it should be `currentValue` together with `defaultValue` and not `currentState` according current apis
I think may be we need to discuss in future if we want to render some things like `Allow multiple selection` checkbox inside of native filter chart so it should be really changed to currentState but for now all filters working only with `currentValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (51818e6) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **increase** coverage by `3.73%`.
> The diff coverage is `44.52%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
+ Coverage 63.23% 66.97% +3.73%
==========================================
Files 1021 1022 +1
Lines 50145 50264 +119
Branches 5204 5246 +42
==========================================
+ Hits 31708 33663 +1955
+ Misses 18222 16467 -1755
+ Partials 215 134 -81
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.88% <42.55%> (?)` | |
| javascript | `61.90% <41.78%> (-0.03%)` | :arrow_down: |
| python | `63.98% <ø> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `39.13% <0.00%> (+4.34%)` | :arrow_up: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.89% <ø> (+0.15%)` | :arrow_up: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `60.86% <ø> (+26.08%)` | :arrow_up: |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (+100.00%)` | :arrow_up: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <25.00%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.74% <27.77%> (+3.67%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `59.09% <36.73%> (-6.95%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `83.60% <64.28%> (-2.51%)` | :arrow_down: |
| ... and [200 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...b91b3f1](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (b91b3f1) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
+ Coverage 63.23% 63.38% +0.15%
==========================================
Files 1021 489 -532
Lines 50145 30180 -19965
Branches 5204 0 -5204
==========================================
- Hits 31708 19129 -12579
+ Misses 18222 11051 -7171
+ Partials 215 0 -215
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.38% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.55% <0.00%> (-5.47%)` | :arrow_down: |
| ... and [546 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...b91b3f1](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (51818e6) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **increase** coverage by `3.59%`.
> The diff coverage is `44.52%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
+ Coverage 63.23% 66.82% +3.59%
==========================================
Files 1021 1022 +1
Lines 50145 50264 +119
Branches 5204 5246 +42
==========================================
+ Hits 31708 33588 +1880
+ Misses 18222 16542 -1680
+ Partials 215 134 -81
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.88% <42.55%> (?)` | |
| javascript | `61.90% <41.78%> (-0.03%)` | :arrow_down: |
| python | `63.73% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `39.13% <0.00%> (+4.34%)` | :arrow_up: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.89% <ø> (+0.15%)` | :arrow_up: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `60.86% <ø> (+26.08%)` | :arrow_up: |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (+100.00%)` | :arrow_up: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <25.00%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.74% <27.77%> (+3.67%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `59.09% <36.73%> (-6.95%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `83.60% <64.28%> (-2.51%)` | :arrow_down: |
| ... and [202 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...b91b3f1](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
simcha90 commented on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-770392908
@junlincc Hi fixed your notes (about 3. it works for me, but may it was fixed by my other changes).
I also needed update some part of code to cause `Reset All` work, so I also updated description of PR with all changes
About multiple values, it can be good idea but I think in other PR in order to not increase size of this one, because implementing of this feature caused some cascading changes in other parts of code, so it have now XL size :)
cc @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (eab3d19) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **decrease** coverage by `12.34%`.
> The diff coverage is `42.26%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
===========================================
- Coverage 63.23% 50.88% -12.35%
===========================================
Files 1021 476 -545
Lines 50145 17237 -32908
Branches 5204 4460 -744
===========================================
- Hits 31708 8771 -22937
+ Misses 18222 8466 -9756
+ Partials 215 0 -215
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.88% <42.26%> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `31.57% <0.00%> (-3.21%)` | :arrow_down: |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `8.33% <0.00%> (-9.85%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-17.81%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `57.14% <ø> (+22.36%)` | :arrow_up: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (+100.00%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `33.82% <29.72%> (-32.22%)` | :arrow_down: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `48.78% <30.76%> (+0.70%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `58.18% <51.61%> (-30.71%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `27.02% <77.77%> (-59.09%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| ... and [936 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...eab3d19](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (10529e9) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **decrease** coverage by `1.35%`.
> The diff coverage is `39.24%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 63.23% 61.88% -1.36%
==========================================
Files 1021 535 -486
Lines 50145 20037 -30108
Branches 5204 5242 +38
==========================================
- Hits 31708 12399 -19309
+ Misses 18222 7424 -10798
+ Partials 215 214 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.88% <39.24%> (-0.06%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <0.00%> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (ø)` | |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `34.78% <ø> (ø)` | |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <7.69%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.36% <30.00%> (+3.29%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `59.09% <36.73%> (-6.95%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `70.00% <55.55%> (-18.89%)` | :arrow_down: |
| ... and [514 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...10529e9](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12199:
URL: https://github.com/apache/superset/pull/12199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (51818e6) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **decrease** coverage by `0.22%`.
> The diff coverage is `41.78%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 63.23% 63.00% -0.23%
==========================================
Files 1021 1022 +1
Lines 50145 50243 +98
Branches 5204 5246 +42
==========================================
- Hits 31708 31656 -52
- Misses 18222 18373 +151
+ Partials 215 214 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.90% <41.78%> (-0.03%)` | :arrow_down: |
| python | `63.73% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <0.00%> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (ø)` | |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `34.78% <ø> (ø)` | |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <25.00%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `50.70% <27.77%> (+2.62%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `59.09% <36.73%> (-6.95%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `70.88% <56.81%> (-18.01%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...51818e6](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (b91b3f1) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **increase** coverage by `0.50%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
+ Coverage 63.23% 63.73% +0.50%
==========================================
Files 1021 489 -532
Lines 50145 30195 -19950
Branches 5204 0 -5204
==========================================
- Hits 31708 19245 -12463
+ Misses 18222 10950 -7272
+ Partials 215 0 -215
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.73% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <0.00%> (ø)` | |
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <0.00%> (ø)` | |
| [...perset-frontend/src/utils/getControlsForVizType.js](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENvbnRyb2xzRm9yVml6VHlwZS5qcw==) | | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...b91b3f1](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on a change in pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
simcha90 commented on a change in pull request #12199:
URL: https://github.com/apache/superset/pull/12199#discussion_r568339098
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -29,12 +29,13 @@ export type AntCallback = (value1?: any, value2?: any) => void;
interface NativeFiltersFormItem {
scope: Scope;
name: string;
+ filterType: FilterType;
dataset: {
value: number;
label: string;
};
column: string;
- defaultValue: string;
+ defaultValue: any;
Review comment:
explained in bottom comment 👇 :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (51818e6) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **decrease** coverage by `0.24%`.
> The diff coverage is `41.78%`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 63.23% 62.98% -0.25%
==========================================
Files 1021 1022 +1
Lines 50145 50243 +98
Branches 5204 5246 +42
==========================================
- Hits 31708 31645 -63
- Misses 18222 18384 +162
+ Partials 215 214 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.90% <41.78%> (-0.03%)` | :arrow_down: |
| python | `63.69% <ø> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <0.00%> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (ø)` | |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `34.78% <ø> (ø)` | |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <25.00%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `50.70% <27.77%> (+2.62%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `59.09% <36.73%> (-6.95%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `70.88% <56.81%> (-18.01%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...51818e6](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on a change in pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
simcha90 commented on a change in pull request #12199:
URL: https://github.com/apache/superset/pull/12199#discussion_r568338774
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -78,15 +82,15 @@ export type FilterType = 'text' | 'date';
export interface Filter {
allowsMultipleValues: boolean;
cascadeParentIds: string[];
- defaultValue: string | null;
- currentValue?: (string | number | boolean)[] | null;
+ defaultValue: any;
+ currentValue?: any;
Review comment:
it's value that we are passing to the native filter, so it should be `currentValue` together with `defaultValue` and not `currentState` according current apis
I think may be we need to discuss in future if we want to render some things like `Allow multiple selection` checkbox inside of native filter chart so it should be really changed to currentState but for now all filters working only with `currentValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (b91b3f1) into [master](https://codecov.io/gh/apache/superset/commit/2b9d5795ada7648943980976b32ac27940ab7778?el=desc) (2b9d579) will **increase** coverage by `0.47%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
+ Coverage 63.23% 63.70% +0.47%
==========================================
Files 1021 489 -532
Lines 50145 30180 -19965
Branches 5204 0 -5204
==========================================
- Hits 31708 19226 -12482
+ Misses 18222 10954 -7268
+ Partials 215 0 -215
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.70% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [532 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [2b9d579...b91b3f1](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: WIP: Add defaultValue for Native filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
# [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=h1) Report
> Merging [#12199](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=desc) (33400b6) into [master](https://codecov.io/gh/apache/superset/commit/49e6e420da517e7348599a53722afc8ab2231559?el=desc) (49e6e42) will **decrease** coverage by `3.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12199 +/- ##
==========================================
- Coverage 66.99% 63.99% -3.01%
==========================================
Files 1022 488 -534
Lines 50049 30142 -19907
Branches 4914 0 -4914
==========================================
- Hits 33532 19288 -14244
+ Misses 16393 10854 -5539
+ Partials 124 0 -124
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.99% <ø> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <0.00%> (-8.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-5.85%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.05% <0.00%> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.58% <0.00%> (ø)` | |
| [superset-frontend/src/addSlice/index.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL2luZGV4LnRzeA==) | | |
| [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | | |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/12199/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=footer). Last update [49e6e42...33400b6](https://codecov.io/gh/apache/superset/pull/12199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-769175777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #12199: feat(native-filters): Add defaultValue for Native filters modal
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12199:
URL: https://github.com/apache/superset/pull/12199#discussion_r567894075
##########
File path: superset-frontend/src/dashboard/actions/nativeFilters.ts
##########
@@ -117,15 +118,18 @@ export function setFilterState(
* Sets the selected option(s) for a given filter
* @param filterId the id of the native filter
* @param extraFormData the selection translated into extra form data
+ * @param currentState
*/
export function setExtraFormData(
filterId: string,
extraFormData: ExtraFormData,
+ currentState: object,
Review comment:
Same here?
##########
File path: superset-frontend/src/dashboard/actions/nativeFilters.ts
##########
@@ -99,6 +99,7 @@ export interface SetExtraFormData {
type: typeof SET_EXTRA_FORM_DATA;
filterId: string;
extraFormData: ExtraFormData;
+ currentState: object;
Review comment:
Should this be of type `CurrentFilterState`?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx
##########
@@ -201,7 +202,11 @@ interface FilterProps {
filter: Filter;
icon?: React.ReactElement;
directPathToChild?: string[];
- onExtraFormDataChange: (filter: Filter, extraFormData: ExtraFormData) => void;
+ onExtraFormDataChange: (
+ filter: Filter,
+ extraFormData: ExtraFormData,
+ currentValue: any,
Review comment:
I believe this was called `currentState` and was of type `CurrentFilterState`. Let's use same naming+type everywhere.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -29,12 +29,13 @@ export type AntCallback = (value1?: any, value2?: any) => void;
interface NativeFiltersFormItem {
scope: Scope;
name: string;
+ filterType: FilterType;
dataset: {
value: number;
label: string;
};
column: string;
- defaultValue: string;
+ defaultValue: any;
Review comment:
Should this be `CurrentFilterState`?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/state.ts
##########
@@ -113,17 +136,70 @@ export function useFilterScopeTree(): {
}
export function useCascadingFilters(id: string) {
- return useSelector<any, ExtraFormData>(state => {
- const { nativeFilters }: { nativeFilters: NativeFiltersState } = state;
- const { filters, filtersState } = nativeFilters;
- const filter = filters[id];
- const cascadeParentIds = filter?.cascadeParentIds ?? [];
- let cascadedFilters = {};
- cascadeParentIds.forEach(parentId => {
- const parentState = filtersState[parentId] || {};
- const { extraFormData: parentExtra = {} } = parentState;
- cascadedFilters = mergeExtraFormData(cascadedFilters, parentExtra);
- });
- return cascadedFilters;
+ const nativeFilters = useSelector<any, NativeFiltersState>(
+ state => state.nativeFilters,
+ );
+ const { filters, filtersState } = nativeFilters;
+ const filter = filters[id];
+ const cascadeParentIds = filter?.cascadeParentIds ?? [];
+ let cascadedFilters = {};
+ cascadeParentIds.forEach(parentId => {
+ const parentState = filtersState[parentId] || {};
+ const { extraFormData: parentExtra = {} } = parentState;
+ cascadedFilters = mergeExtraFormData(cascadedFilters, parentExtra);
});
+ return cascadedFilters;
}
+
+// When some fields in form changed we need re-fetch data for Filter defaultValue
+export const useBEFormUpdate = (
Review comment:
This could be named more descriptively, maybe `useBackendFormUpdate`.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -78,15 +82,15 @@ export type FilterType = 'text' | 'date';
export interface Filter {
allowsMultipleValues: boolean;
cascadeParentIds: string[];
- defaultValue: string | null;
- currentValue?: (string | number | boolean)[] | null;
+ defaultValue: any;
+ currentValue?: any;
Review comment:
Same here
##########
File path: superset-frontend/src/filters/components/Select/types.ts
##########
@@ -45,7 +46,8 @@ export type AntdPluginFilterSelectProps = AntdPluginFilterStylesProps & {
};
export const DEFAULT_FORM_DATA: AntdPluginFilterSelectCustomizeProps = {
- defaultValues: [],
+ defaultValue: [],
+ currentValue: [],
Review comment:
Should these default to `null`?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/CascadePopover.tsx
##########
@@ -22,14 +22,19 @@ import Popover from 'src/common/components/Popover';
import Icon from 'src/components/Icon';
import { Pill } from 'src/dashboard/components/FiltersBadge/Styles';
import { CascadeFilterControl, FilterControl } from './FilterBar';
-import { Filter, CascadeFilter } from './types';
+import { Filter, CascadeFilter, CurrentFilterState } from './types';
+import { useFilterState } from './state';
interface CascadePopoverProps {
filter: CascadeFilter;
visible: boolean;
directPathToChild?: string[];
onVisibleChange: (visible: boolean) => void;
- onExtraFormDataChange: (filter: Filter, extraFormData: ExtraFormData) => void;
+ onExtraFormDataChange: (
+ filter: Filter,
+ extraFormData: ExtraFormData,
+ currentState: CurrentFilterState,
+ ) => void;
Review comment:
we need to think of a better name for this now that the scope has changed. `onFilterSelectionChange`?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/state.ts
##########
@@ -27,14 +27,24 @@ import {
CHART_TYPE,
DASHBOARD_ROOT_TYPE,
} from 'src/dashboard/util/componentTypes';
+import { FormInstance } from 'antd/lib/form';
import {
+ CurrentFilterState,
Filter,
FilterConfiguration,
FilterState,
+ NativeFiltersForm,
NativeFiltersState,
TreeItem,
} from './types';
-import { buildTree, mergeExtraFormData } from './utils';
+import {
+ buildTree,
+ getFormData,
+ mergeExtraFormData,
+ setFilterFieldValues,
+ useForceUpdate,
+} from './utils';
+import { getChartDataRequest } from '../../../chart/chartAction';
Review comment:
nit:
```suggestion
import { getChartDataRequest } from 'src/chart/chartAction';
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -99,11 +103,15 @@ export interface CascadeFilter extends Filter {
export type FilterConfiguration = Filter[];
export type SelectedValues = string[] | null;
+export type CurrentFilterState = {
+ value: any;
+};
Review comment:
`CurrentFilterState` could be an alias for `JsonObject` from `@superset-ui/core` for now (making it an alias makes it easier for us to make this more specific in the future if needed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org