You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/18 11:34:17 UTC

[GitHub] [netbeans] tbw777 opened a new pull request, #5311: Replaced replaceAll() calls to replace()

tbw777 opened a new pull request, #5311:
URL: https://github.com/apache/netbeans/pull/5311

   replace() method is more fast then replaceAll() for non regex cases
   
   Tests to proof correctly changes:
   `        {
               var testStr = "...|string ||. |||...||||";
   
               var str1 = testStr.replace("|", "");
               var str2 = testStr.replaceAll("|", "");
               test(str1, str2);
   
               // ...string . ...
               // ...|string ||. |||...||||
               // FALSE
           }
   
           {
               var testStr = "\\ABC \\\\ ASDF 4\\\\FDS \\ sdf \\ asdf \\\\\\";
   
               //equals
               var str1 = testStr.replace("\\", "/");
               var str2 = testStr.replaceAll("\\\\", "/");
               test(str1, str2);
   
               // /ABC // ASDF 4//FDS / sdf / asdf ///
               // /ABC // ASDF 4//FDS / sdf / asdf ///
               // true
           }
   
           {
               var testStr = "...\\string \\. \\...";
   
               var str1 = testStr.replace(".", "");
               var str2 = testStr.replaceAll("\\.", "");
               test(str1, str2);
   
               // \string \ \
               // \string \ \
               // true
           }
   
           {
               var testStr = ".{{..{string {\\} 1234{\\\\\\{}. \\{{{{...\\\\{...\\\\\\\\{{{";
   
               var str1 = testStr.replace("{", "'{'");
               var str2 = testStr.replaceAll("\\{", "'\\{'");
               test(str1, str2);
   
               // .'{''{'..'{'string '{'\} 1234'{'\\\'{'}. \'{''{''{''{'...\\'{'...\\\\'{''{''{'
               // .'{''{'..'{'string '{'\} 1234'{'\\\'{'}. \'{''{''{''{'...\\'{'...\\\\'{''{''{'
               // true
           }
   
           {
               var testStr = ".}}..}string }\\} 1234}\\\\\\}}. \\}}}}...\\\\}...\\\\\\\\}}}";
   
               var str1 = testStr.replace("}", "'}'");
               var str2 = testStr.replaceAll("\\}", "'\\}'");
               test(str1, str2);
   
               // .'}''}'..'}'string '}'\'}' 1234'}'\\\'}''}'. \'}''}''}''}'...\\'}'...\\\\'}''}''}'
               // .'}''}'..'}'string '}'\'}' 1234'}'\\\'}''}'. \'}''}''}''}'...\\'}'...\\\\'}''}''}'
               // true
           }
   
           {
               var testStr = ".}}..'{'st'}'\\} 1234}\\\\\\}}. \\}}'{'st}} {'st'}'...''{'st'}'\\\\}...\\\\\\\\}''{'st'}''}}";
   
               var str1 = testStr.replace("'{'" + "st" + "'}'","{" + "st" + "}");
               var str2 = testStr.replaceAll("'\\{'" + "st" + "'\\}'", "\\{" + "st" + "\\}");
               test(str1, str2);
   
               // .}}..{st}\} 1234}\\\}}. \}}'{'st}} {'st'}'...'{st}\\}...\\\\}'{st}'}}
               // .}}..{st}\} 1234}\\\}}. \}}'{'st}} {'st'}'...'{st}\\}...\\\\}'{st}'}}
               // true
           }
   
           {
               var testStr = "abc\nabcd\n\nabcd123\n\n\n";
   
               var str1 = testStr.replace("\n", "<br>");
               var str2 = testStr.replaceAll("\\n", "<br>");
               test(str1, str2);
   
               // abc<br>abcd<br><br>abcd123<br><br><br>
               // abc<br>abcd<br><br>abcd123<br><br><br>
               // true
           }
   
           {
               var testStr = "\\\\ \\ \\\\\\ \\\\1 \\2 \\\\\\3 \\\\d \\d \\\\\\d \\\\\\ddd";
   
               var str1 = testStr.replace("\\d", ":");
               var str2 = testStr.replaceAll("\\\\d", ":");
               test(str1, str2);
   
               // \\ \ \\\ \\1 \2 \\\3 \: : \\: \\:dd
               // \\ \ \\\ \\1 \2 \\\3 \: : \\: \\:dd
               // true
           }
   
           {
               var testStr = "\\\\ \\ \\\\\\ \\\\1 \\2 \\\\\\3 \\\\n \\n \\\\\\n \\\\\\n \n\n \\\\ n\n";
   
               var str1 = testStr.replace("\\n", " ");
               var str2 = testStr.replaceAll("\\\\n", " ");
               test(str1, str2);
   
               // \\ \ \\\ \\1 \2 \\\3 \    \\  \\
               //
               //  \\ n
               //
               // \\ \ \\\ \\1 \2 \\\3 \    \\  \\
               //
               //  \\ n
               //
               // true
           }
   
   
           {
               var testStr = "\\\\ \\ \\\\\\ \\\\1 \\2 \\\\\\3 \\\\ \\ \\\\\\ \\\\\\ \\ \\\\ n\\";
   
               var str1 = testStr.replace("\\\\", "\\");
               var str2 = testStr.replaceAll("\\\\\\\\", "\\\\");
               test(str1, str2);
   
               // \ \ \\ \1 \2 \\3 \ \ \\ \\ \ \ n\
               // \ \ \\ \1 \2 \\3 \ \ \\ \\ \ \ n\
               // true
           }
   
           //
   
           {
               var testStr = "\\\\ \\ \\\\\\ \\\\1 \\2 \\\\\\3 \\\\ \\ \\\\\\ \\\\\\ \\ \\\\ n\\";
   
               var str1 = testStr.replace("\\", "/");
               var str2 = testStr.replaceAll("\\\\", "/");
               test(str1, str2);
   
               // // / /// //1 /2 ///3 // / /// /// / // n/
               // // / /// //1 /2 ///3 // / /// /// / // n/
               // true
           }
   
           {
               var testStr = "\\\\ \\ \\   \\ \\\\1 \\2 \\    3 \\\\ \\ \\\\\\ \\\\\\ \\ \\\\ n\\";
   
               var str1 = testStr.replace(" ", "%20");
               var str2 = testStr.replaceAll(" ", "%20");
               test(str1, str2);
   
               // \\%20\%20\%20%20%20\%20\\1%20\2%20\%20%20%20%203%20\\%20\%20\\\%20\\\%20\%20\\%20n\
               // \\%20\%20\%20%20%20\%20\\1%20\2%20\%20%20%20%203%20\\%20\%20\\\%20\\\%20\%20\\%20n\
               // true
           }
   
           {
               var testStr = "\\\\ \\ \\   \\ \\\\1 \\2 \\    3 \\\\ \\ \\\\\\ \\\\\\ \\ \\\\ n\\";
   
               var str1 = testStr.replace(" ", "");
               var str2 = testStr.replaceAll(" +", "");
               test(str1, str2);
   
               // \\\\\\\1\2\3\\\\\\\\\\\\n\
               // \\\\\\\1\2\3\\\\\\\\\\\\n\
               // true
           }
   
           {
               var testStr = "\\\\*\\*\\***\\*\\\\1*\\2*\\****3*\\\\*\\*\\\\\\*\\\\\\*\\*\\\\*n\\";
   
               var str1 = testStr.replace("**", "(.+/)?");
               var str2 = testStr.replaceAll("\\*\\*", "(.+/)?");
               test(str1, str2);
   
               // \\*\*\(.+/)?*\*\\1*\2*\(.+/)?(.+/)?3*\\*\*\\\*\\\*\*\\*n\
               // \\*\*\(.+/)?*\*\\1*\2*\(.+/)?(.+/)?3*\\*\*\\\*\\\*\*\\*n\
               // true
           }
   
           {
               var testStr = "\\\\*\\*\\***\\*\\\\1*\\2*\\****3*\\\\*\\*\\\\\\*\\\\\\*\\*\\\\*n\\";
   
               var str1 = testStr.replace("*", "(.+/)?");
               var str2 = testStr.replaceAll("\\*", "(.+/)?");
               test(str1, str2);
   
               // \\(.+/)?\(.+/)?\(.+/)?(.+/)?(.+/)?\(.+/)?\\1(.+/)?\2(.+/)?\(.+/)?(.+/)?(.+/)?(.+/)?3(.+/)?\\(.+/)?\(.+/)?\\\(.+/)?\\\(.+/)?\(.+/)?\\(.+/)?n\
               // \\(.+/)?\(.+/)?\(.+/)?(.+/)?(.+/)?\(.+/)?\\1(.+/)?\2(.+/)?\(.+/)?(.+/)?(.+/)?(.+/)?3(.+/)?\\(.+/)?\(.+/)?\\\(.+/)?\\\(.+/)?\(.+/)?\\(.+/)?n\
               // true
           }
   
           {
               var testStr = "\\\\ \\ \\   \\ \\\\1 \\2 \\    3 \\\\ \\ \\\\\\ \\\\\\ \\ \\\\ n\\";
   
               var str1 = testStr.replace("  ", " ");
               var str2 = testStr.replaceAll(" +", " ");
               test(str1, str2);
   
               // \\ \ \  \ \\1 \2 \  3 \\ \ \\\ \\\ \ \\ n\
               // \\ \ \ \ \\1 \2 \ 3 \\ \ \\\ \\\ \ \\ n\
               // FALSE
           }
   
   
           {
               var testStr = "\\\\ \\ \\   \\ \\\\1 \\2 \\    3 \\\\ \\ \\\\\\ \\\\\\ \\ \\\\ n\\";
   
               var str1 = testStr.replace(" ", " ");
               var str2 = testStr.replaceAll(" ", " ");
               test(str1, str2);
   
               // \\ \ \   \ \\1 \2 \    3 \\ \ \\\ \\\ \ \\ n\
               // \\ \ \   \ \\1 \2 \    3 \\ \ \\\ \\\ \ \\ n\
               // true
           }
   
           {
               var testStr = " / / / /  / /  / /    / /  / / / /1  / /2  / /    3  / / / /  / /  / / / / / /  / / / / / /  / /  / / / / n / /";
   
               var str1 = testStr.replace(".", "\\*");
               var str2 = testStr.replaceAll(".", "\\*");
               test(str1, str2);
   
               //  / / / /  / /  / /    / /  / / / /1  / /2  / /    3  / / / /  / /  / / / / / /  / / / / / /  / /  / / / / n / /
               // ***************************************************************************************************************
               // FALSE
           }
   
           {
               var testStr = "#/#/#/#/##/#/##/#/####/#/##/#/#/#/1##/#/2##/#/####3##/#/#/#/##/#/##/#/#/#/#/#/##/#/#/#/#/#/##/#/##/#/#/#/#n#/#/";
   
               var str1 = testStr.replace("#", "\"");
               var str2 = testStr.replaceAll("#", "\"");
               test(str1, str2);
   
               // "/"/"/"/""/"/""/"/""""/"/""/"/"/"/1""/"/2""/"/""""3""/"/"/"/""/"/""/"/"/"/"/"/""/"/"/"/"/"/""/"/""/"/"/"/"n"/"/
               // "/"/"/"/""/"/""/"/""""/"/""/"/"/"/1""/"/2""/"/""""3""/"/"/"/""/"/""/"/"/"/"/"/""/"/"/"/"/"/""/"/""/"/"/"/"n"/"/
               // true
           }
   
   
           {
               var testStr = ",/,/,/,/,,/,/,,/,/,,,,/,/,,/,/,/,/1,,/,/2,,/,/,,,,3,,/,/,/,/,,/,/,,/,/,/,/,/,/,,/,/,/,/,/,/,,/,/,,/,/,/,/,n,/,/";
   
               var str1 = testStr.replace(",", "1");
               var str2 = testStr.replaceAll(",", "1");
               test(str1, str2);
   
               // 1/1/1/1/11/1/11/1/1111/1/11/1/1/1/111/1/211/1/1111311/1/1/1/11/1/11/1/1/1/1/1/11/1/1/1/1/1/11/1/11/1/1/1/1n1/1/
               // 1/1/1/1/11/1/11/1/1111/1/11/1/1/1/111/1/211/1/1111311/1/1/1/11/1/11/1/1/1/1/1/11/1/1/1/1/1/11/1/11/1/1/1/1n1/1/
               // true
           }
   
           {
               var testStr = "-/-/-/-/--/-/--/-/----/-/--/-/-/-/1--/-/2--/-/----3--/-/-/-/--/-/--/-/-/-/-/-/--/-/-/-/-/-/--/-/--/-/-/-/-n-/-/";
   
               var str1 = testStr.replace("-", "1");
               var str2 = testStr.replaceAll("-", "1");
               test(str1, str2);
   
               // 1/1/1/1/11/1/11/1/1111/1/11/1/1/1/111/1/211/1/1111311/1/1/1/11/1/11/1/1/1/1/1/11/1/1/1/1/1/11/1/11/1/1/1/1n1/1/
               // 1/1/1/1/11/1/11/1/1111/1/11/1/1/1/111/1/211/1/1111311/1/1/1/11/1/11/1/1/1/1/1/11/1/1/1/1/1/11/1/11/1/1/1/1n1/1/
               // true
           }`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on a diff in pull request #5311: Replaced replaceAll() calls to replace()

Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5311:
URL: https://github.com/apache/netbeans/pull/5311#discussion_r1080731688


##########
ide/bugtracking.bridge/src/org/netbeans/modules/bugtracking/vcs/HookUtils.java:
##########
@@ -43,16 +43,10 @@ public class HookUtils {
      * @return
      */
     public static String prepareFormatString(String formatString, String... keys) {
-        formatString = formatString.replaceAll("\\{", "'\\{'");                 // NOI18N
-        formatString = formatString.replaceAll("\\}", "'\\}'");                 // NOI18N
-        for (int i = 0; i < keys.length; i++) {
-            String key = keys[i];
-            formatString =
-                formatString.replaceAll(
-                    "'\\{'" + key + "'\\}'",                                    // NOI18N
-                    "\\{" + i + "\\}"                                           // NOI18N
-                );
-
+        formatString = formatString.replace("{", "'{'");                 // NOI18N
+        formatString = formatString.replace("}", "'}'");                 // NOI18N
+        for (String key : keys) {
+            formatString = formatString.replace("'{'" + key + "'}'", "{" + key + "}");
         }

Review Comment:
   second `key` should be `i` but you removed the index from the loop, so you have to revert that too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #5311: Replaced replaceAll() calls to replace()

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5311:
URL: https://github.com/apache/netbeans/pull/5311#issuecomment-1396926899

   please make sure that tests are passing locally before pushing into the PR on follow ups, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tbw777 commented on a diff in pull request #5311: Replaced replaceAll() calls to replace()

Posted by GitBox <gi...@apache.org>.
tbw777 commented on code in PR #5311:
URL: https://github.com/apache/netbeans/pull/5311#discussion_r1081296565


##########
ide/docker.api/src/org/netbeans/modules/docker/IgnorePattern.java:
##########
@@ -108,7 +108,7 @@ static String preprocess(String pattern, char separator) {
         }
 
         ret = ret.replaceAll("^(" + Pattern.quote(sep) + "\\.\\.)+(" + Pattern.quote(sep) +")?", Matcher.quoteReplacement(sep))
-                .replaceAll("/", Matcher.quoteReplacement(sep));
+                .replace("/", Matcher.quoteReplacement(sep));

Review Comment:
   great



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on a diff in pull request #5311: Replaced replaceAll() calls to replace()

Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5311:
URL: https://github.com/apache/netbeans/pull/5311#discussion_r1081212416


##########
ide/bugtracking.bridge/src/org/netbeans/modules/bugtracking/vcs/HookUtils.java:
##########
@@ -43,16 +43,11 @@ public class HookUtils {
      * @return
      */
     public static String prepareFormatString(String formatString, String... keys) {
-        formatString = formatString.replaceAll("\\{", "'\\{'");                 // NOI18N
-        formatString = formatString.replaceAll("\\}", "'\\}'");                 // NOI18N
+        formatString = formatString.replace("{", "'{'");                 // NOI18N
+        formatString = formatString.replace("}", "'}'");                 // NOI18N
         for (int i = 0; i < keys.length; i++) {
             String key = keys[i];
-            formatString =
-                formatString.replaceAll(
-                    "'\\{'" + key + "'\\}'",                                    // NOI18N
-                    "\\{" + i + "\\}"                                           // NOI18N
-                );
-
+            formatString = formatString.replace("'{'" + key + "'}'", "{" + i + "}");

Review Comment:
   how do you know that key is not a regexp?



##########
ide/docker.api/src/org/netbeans/modules/docker/IgnorePattern.java:
##########
@@ -108,7 +108,7 @@ static String preprocess(String pattern, char separator) {
         }
 
         ret = ret.replaceAll("^(" + Pattern.quote(sep) + "\\.\\.)+(" + Pattern.quote(sep) +")?", Matcher.quoteReplacement(sep))
-                .replaceAll("/", Matcher.quoteReplacement(sep));
+                .replace("/", Matcher.quoteReplacement(sep));

Review Comment:
   this might be wrong since `quoteReplacement` will have a different effect when passed to `replace` instead of `replaceAll`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tbw777 commented on a diff in pull request #5311: Replaced replaceAll() calls to replace()

Posted by GitBox <gi...@apache.org>.
tbw777 commented on code in PR #5311:
URL: https://github.com/apache/netbeans/pull/5311#discussion_r1080737657


##########
ide/bugtracking.bridge/src/org/netbeans/modules/bugtracking/vcs/HookUtils.java:
##########
@@ -43,16 +43,10 @@ public class HookUtils {
      * @return
      */
     public static String prepareFormatString(String formatString, String... keys) {
-        formatString = formatString.replaceAll("\\{", "'\\{'");                 // NOI18N
-        formatString = formatString.replaceAll("\\}", "'\\}'");                 // NOI18N
-        for (int i = 0; i < keys.length; i++) {
-            String key = keys[i];
-            formatString =
-                formatString.replaceAll(
-                    "'\\{'" + key + "'\\}'",                                    // NOI18N
-                    "\\{" + i + "\\}"                                           // NOI18N
-                );
-
+        formatString = formatString.replace("{", "'{'");                 // NOI18N
+        formatString = formatString.replace("}", "'}'");                 // NOI18N
+        for (String key : keys) {
+            formatString = formatString.replace("'{'" + key + "'}'", "{" + key + "}");
         }

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tbw777 commented on pull request #5311: Replaced replaceAll() calls to replace()

Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5311:
URL: https://github.com/apache/netbeans/pull/5311#issuecomment-1396970616

   > please make sure that tests are passing locally before pushing into the PR on follow ups, thanks
   
   Is this a tests failure ?
   
   
   Download action repository 'actions/setup-java@v3' (SHA:1df8dbefe2a8cbc99770194893dd902763bee34b)
   Warning: Failed to download action 'https://api.github.com/repos/actions/setup-java/tarball/1df8dbefe2a8cbc99770194893dd902763bee34b'. Error: Response status code does not indicate success: 502 (Bad Gateway).
   Warning: Back off 21.789 seconds before retry.
   Warning: Failed to download action 'https://api.github.com/repos/actions/setup-java/tarball/1df8dbefe2a8cbc99770194893dd902763bee[34](https://github.com/apache/netbeans/actions/runs/3954617726/jobs/6772143738#step:1:38)b'. Error: Error while copying content to a stream.
   Warning: Back off 13.815 seconds before retry.
   Error: Error while copying content to a stream.
   /home/runner/work/netbeans/netbeans/nbbuild/build.xml:166: Can't get https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json to /home/runner/work/netbeans/netbeans/nbbuild/build/netbeansrelease.json
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tbw777 commented on pull request #5311: Replaced replaceAll() calls to replace()

Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5311:
URL: https://github.com/apache/netbeans/pull/5311#issuecomment-1397018261

   > this is an unrelated CI problem, I don't know what is causing this.
   > 
   > This PR failed multiple times before, e.g yesterday: https://github.com/apache/netbeans/actions/runs/3948453581
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #5311: Replaced replaceAll() calls to replace()

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5311:
URL: https://github.com/apache/netbeans/pull/5311#issuecomment-1397014894

   this is an unrelated CI problem, I don't know what is causing this.
   
   This PR failed multiple times before, e.g yesterday:
   https://github.com/apache/netbeans/actions/runs/3948453581


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tbw777 closed pull request #5311: Replaced replaceAll() calls to replace()

Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5311: Replaced replaceAll() calls to replace()
URL: https://github.com/apache/netbeans/pull/5311


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists