You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by raviperi <gi...@git.apache.org> on 2016/10/03 18:04:56 UTC

[GitHub] storm pull request #1702: Update Eventhub-Client jar dependency to 1.0.1

Github user raviperi commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1702#discussion_r81605840
  
    --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpout.java ---
    @@ -121,8 +121,8 @@ public void preparePartitions(Map config, int totalTasks, int taskIndex, SpoutOu
             zkEndpointAddress = sb.toString();
           }
           stateStore = new ZookeeperStateStore(zkEndpointAddress,
    -          (Integer)config.get(Config.STORM_ZOOKEEPER_RETRY_TIMES),
    -          (Integer)config.get(Config.STORM_ZOOKEEPER_RETRY_INTERVAL));
    +          Integer.parseInt(config.get(Config.STORM_ZOOKEEPER_RETRY_TIMES).toString()),
    --- End diff --
    
    It compiles :) 
    
    The issue was that the values were being parsed as Long, and not Integer.
    Instead of doing an explicit cast, I wanted to be safe and parse the numeric value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---