You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/06/05 10:53:24 UTC
[jira] [Commented] (THRIFT-1996) JavaME Constants generation is
broken / inconsistent with regular Java generation
[ https://issues.apache.org/jira/browse/THRIFT-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675717#comment-13675717 ]
Hudson commented on THRIFT-1996:
--------------------------------
Integrated in Thrift #662 (See [https://builds.apache.org/job/Thrift/662/])
THRIFT-1996:Constants generation is broken / inconsistent with regular Java generation (Revision 1b0bc0f42106700e45ce2e76049eefa6f57c1293)
Result = FAILURE
jfarrell :
Files :
* compiler/cpp/src/generate/t_javame_generator.cc
* compiler/cpp/src/generate/t_as3_generator.cc
> JavaME Constants generation is broken / inconsistent with regular Java generation
> ---------------------------------------------------------------------------------
>
> Key: THRIFT-1996
> URL: https://issues.apache.org/jira/browse/THRIFT-1996
> Project: Thrift
> Issue Type: Bug
> Components: JavaME - Compiler
> Affects Versions: 0.9
> Environment: NA
> Reporter: Matthew Rathbone
> Priority: Minor
> Fix For: 1.0
>
> Attachments: 0001-javame-constants-win.patch
>
>
> So say you have a namespace 'com.example', and in this namespace you have constant definitions in multiple files:
> Example1.thrift, Example2.thrift
> Generating either of these files compiles to com/example/Constants.java
> So you cannot have more than one file containing constants in this namespace, as compiling Example2 overrides the code compiled from Example1.
> In the regular java codegen the compile paths are different:
> Example1.thrift => Example1Constants.java
> Example2.thrift => Example2Constants.java
> This seems to be the optimal solution as losing code is never good. I've patched the Javame compiler to act the same as the Java compiler (will attach a patch)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira