[GitHub] [opennlp-sandbox] kinow commented on a diff in pull request #62: Update sandbox component 'modelbuilder-addon' to be compatible with latest opennlp-tools release

["kinow (via GitHub)" <gi...@apache.org>]

kinow commented on code in PR #62:
URL: https://github.com/apache/opennlp-sandbox/pull/62#discussion_r1082912447


##########
modelbuilder-addon/src/main/java/opennlp/addons/modelbuilder/DefaultModelBuilderUtil.java:
##########
@@ -98,17 +96,17 @@ public static void generateModel(File sentences, File knownEntities, File knownE
      */
     ModelGenerationValidator validator = new FileModelValidatorImpl();
     validator.setParameters(params);
-    /**
+    /*
      * Modelable's write and read the annotated sentences, as well as create and
      * write the NER models
      */
     Modelable modelable = new GenericModelableImpl();
     modelable.setParameters(params);
 
-    /**
+    /*
      * the modelGenerator actually runs the process with a set number of
      * iterations... could be better by actually calculating the diff between
-     * runs and stopping based on a thresh, but for extrememly large sentence
+     * runs and stopping based on a thresh, but for extremely large sentence

Review Comment:
   Also s/thresh/threshol



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org