[GitHub] [arrow] kiszk commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

[GitBox <gi...@apache.org>]

kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r521123817



##########
File path: cpp/src/arrow/type.h
##########
@@ -1604,13 +1605,26 @@ class ARROW_EXPORT FieldRef {
 // ----------------------------------------------------------------------
 // Schema
 
+enum class Endianness {
+  LITTLE = 0,
+  BIG = 1,
+#if ARROW_LITTLE_ENDIAN
+  NATIVE = LITTLE
+#else
+  NATIVE = BIG
+#endif
+};

Review comment:
       @wesm Good point. To have an endianness flag in the Schema causes an inefficiency that passes this property as an argument.   
   Do you want me to add an endian flag to `DataType` at https://github.com/apache/arrow/blob/master/cpp/src/arrow/type.h#L176 in this PR?
   cc @pitrou 
   
   For my reference, there is an API in Numpy at https://numpy.org/doc/stable/reference/generated/numpy.dtype.byteorder.html.
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org