You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/06/08 17:26:22 UTC
[GitHub] uliian opened a new pull request #337: [ISSUE #336]add
DelayTimeLevel enum
uliian opened a new pull request #337: [ISSUE #336]add DelayTimeLevel enum
URL: https://github.com/apache/rocketmq/pull/337
Please do not create a Pull Request without creating an issue first.
## What is the purpose of the change
Add DelayTimeLevel enum;
add setDelayTimeLevel(DelayTimeLevel level) method;
## Brief changelog
Because I used ROCKETMQ for the first time, I was very puzzled about the setdelaytimelevel function when I used the delay function, it took a lot of time to find the solution, so I wanted to add an enum to more intuitively Setdelaytimelevel
## Verifying this change
run unit test testGenerate_Delay_Enum()
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services