You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/03/04 09:55:09 UTC

[GitHub] [jackrabbit-oak] jelmini commented on a change in pull request #506: OAK-9712 - Add support for Azure SAS URIs in oak-run

jelmini commented on a change in pull request #506:
URL: https://github.com/apache/jackrabbit-oak/pull/506#discussion_r819424884



##########
File path: oak-segment-azure/src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTestBase.java
##########
@@ -69,7 +82,7 @@
 
     protected abstract SegmentNodeStorePersistence getDestPersistence() throws Exception;
 
-    protected abstract String getSrcPathOrUri();
+    protected abstract String getSrcPathOrUri() throws URISyntaxException, InvalidKeyException, StorageException, Exception;

Review comment:
       I suggest to remove all these exceptions here and and modify `getAzurePersistencePathOrUriSas()`to catch all exceptions and rethrow a RuntimeException.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org