You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/24 03:46:45 UTC
[GitHub] [incubator-echarts] pissang opened a new pull request #13337: [5.0] [Feature] support largest-triangle-three-buckets based on 13317
pissang opened a new pull request #13337:
URL: https://github.com/apache/incubator-echarts/pull/13337
This pull request is forked from the PR https://github.com/apache/incubator-echarts/pull/13317 by @SnailSword and did some modifications. Includes:
+ Improve the performance of LTTB downsample, remove unnecessary temporary array creation in the original `getPair` internal method.
+ Fix bugs in some edge cases of LTTB downsample like NaN data handling.
+ Fix `params.start` and `params.end` in the task is not the number after downsampled when using downsample without dataZoom. Which leads downsample don't have any performance improvement.
+ Add performance and result comparison in the test case.
Here is a screenshot of test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13337: [5.0] [Feature] support largest-triangle-three-buckets based on 13317
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13337:
URL: https://github.com/apache/incubator-echarts/pull/13337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13337: [5.0] [Feature] support largest-triangle-three-buckets based on 13317
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13337:
URL: https://github.com/apache/incubator-echarts/pull/13337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13337: [5.0] [Feature] support largest-triangle-three-buckets based on 13317
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13337:
URL: https://github.com/apache/incubator-echarts/pull/13337#issuecomment-698162539
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13337: [5.0] [Feature] support largest-triangle-three-buckets based on 13317
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13337:
URL: https://github.com/apache/incubator-echarts/pull/13337#issuecomment-698093809
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13337: [5.0] [Feature] support largest-triangle-three-buckets based on 13317
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13337:
URL: https://github.com/apache/incubator-echarts/pull/13337#issuecomment-698093809
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org