You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2021/03/30 22:36:03 UTC

[Impala-ASF-CR] Bump up the GBN number to 11920537 

Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17243


Change subject: Bump up the GBN number to 11920537
......................................................................

Bump up the GBN number to 11920537

This change bumps up the GBN to 11920537 which includes several
changes to Hive needed to support Catalogd's HMS endpoint for
supporting external frontends.

Additionally, it excludes some dependencies from the pom.xml
which are not uploaded by default to the toolchain.

Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
---
M bin/impala-config.sh
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
4 files changed, 28 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/17243/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 2:

> Looked at the GVO failure.
 > testAcidMinorCompactionLoading failed because our version of Hive
 > doesn't write '_orc_acid_version' anymore. So I think we should
 > just change the expected value to 8.
 > 
 > I'm working on the fix for test_alter_iceberg_tables:
 > https://gerrit.cloudera.org/#/c/17248/

Thanks for looking into the failures. I updated FileMetadataLoaderTest as suggested.


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:34:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8469/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 22:57:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7024/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 23:44:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7024/


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 05:24:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 07:57:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 1:

Looked at the GVO failure.
testAcidMinorCompactionLoading failed because our version of Hive doesn't write '_orc_acid_version' anymore. So I think we should just change the expected value to 8.

I'm working on the fix for test_alter_iceberg_tables: https://gerrit.cloudera.org/#/c/17248/


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 15:45:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 13:44:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 07:57:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7043/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 07:57:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8484/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 23:06:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................

Bump up the GBN number to 11920537

This change bumps up the GBN to 11920537 which includes several
changes to Hive needed to support Catalogd's HMS endpoint for
supporting external frontends.

Additionally, it excludes some dependencies from the pom.xml
which are not uploaded by default to the toolchain.

After the GBN bump up Hive doesn't write '_orc_acid_version'
files and hence the FileMetadataLoaderTest needed to be
modified.

Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Reviewed-on: http://gerrit.cloudera.org:8080/17243
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
5 files changed, 29 insertions(+), 14 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] Bump up the GBN number to 11920537

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17243 )

Change subject: Bump up the GBN number to 11920537
......................................................................

Bump up the GBN number to 11920537

This change bumps up the GBN to 11920537 which includes several
changes to Hive needed to support Catalogd's HMS endpoint for
supporting external frontends.

Additionally, it excludes some dependencies from the pom.xml
which are not uploaded by default to the toolchain.

After the GBN bump up Hive doesn't write '_orc_acid_version'
files and hence the FileMetadataLoaderTest needed to be
modified.

Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
5 files changed, 29 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/17243/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If88ceeaffc94e5bedf2c9953122109e20663f743
Gerrit-Change-Number: 17243
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>