[GitHub] [nifi] exceptionfactory commented on a change in pull request #5375: Most of NIFI-9096 through NIFI-9142 (JUnit 5)

[GitBox <gi...@apache.org>]

exceptionfactory commented on a change in pull request #5375:
URL: https://github.com/apache/nifi/pull/5375#discussion_r773597838



##########
File path: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/PutGCSObjectTest.java
##########
@@ -48,25 +68,6 @@
 import static org.mockito.Mockito.reset;
 import static org.mockito.Mockito.when;
 
-import com.google.cloud.storage.Acl;
-import com.google.cloud.storage.Blob;
-import com.google.cloud.storage.BlobInfo;
-import com.google.cloud.storage.Storage;
-import com.google.cloud.storage.StorageException;
-import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.ImmutableSet;
-import java.io.InputStream;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import org.apache.nifi.flowfile.attributes.CoreAttributes;
-import org.apache.nifi.util.MockFlowFile;
-import org.apache.nifi.util.TestRunner;
-import org.junit.Test;
-import org.mockito.ArgumentCaptor;
-import org.mockito.Captor;
-import org.mockito.Mock;
-
 /**
  * Unit tests for {@link PutGCSObject} which do not use Google Cloud resources.

Review comment:
       It looks like this class is still using JUnit 4 assertions.

##########
File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/AbstractHadoopTest.java
##########
@@ -117,26 +117,35 @@ public void testErrorConditions() {
         if (pc instanceof MockProcessContext) {
             results = ((MockProcessContext) pc).validate();
         }
-        Assert.assertEquals(1, results.size());
+        assertEquals(1, results.size());
     }
 
     @Test
-    public void testTimeoutDetection() throws Exception {
+    public void testTimeoutDetection() {
         SimpleHadoopProcessor processor = new SimpleHadoopProcessor(kerberosProperties);
         TestRunner runner = TestRunners.newTestRunner(processor);
-        try {
+        assertThrows(IOException.class, () -> {
             final File brokenCoreSite = new File("src/test/resources/core-site-broken.xml");
             final ResourceReference brokenCoreSiteReference = new FileResourceReference(brokenCoreSite);
             final ResourceReferences references = new StandardResourceReferences(Collections.singletonList(brokenCoreSiteReference));
             final List<String> locations = references.asLocations();
             processor.resetHDFSResources(locations, runner.getProcessContext());
-            Assert.fail("Should have thrown SocketTimeoutException");
-        } catch (IOException e) {
-        }
+        });
+
+//        try {
+//            final File brokenCoreSite = new File("src/test/resources/core-site-broken.xml");
+//            final ResourceReference brokenCoreSiteReference = new FileResourceReference(brokenCoreSite);
+//            final ResourceReferences references = new StandardResourceReferences(Collections.singletonList(brokenCoreSiteReference));
+//            final List<String> locations = references.asLocations();
+//            processor.resetHDFSResources(locations, runner.getProcessContext());
+//            Assert.fail("Should have thrown SocketTimeoutException");
+//        } catch (IOException e) {
+//            e.printStackTrace();
+//        }

Review comment:
       Should this be removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org