You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/03/04 17:40:51 UTC

Review Request 18734: Nagios, HIVE-METASTORE servicegroup is not correct, should be HIVE

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18734/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-4936
    https://issues.apache.org/jira/browse/AMBARI-4936


Repository: ambari


Description
-------

...


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh 3e4c61a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 233051f 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 5b56354 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh 0982606 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 a22f208 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 edc36c6 

Diff: https://reviews.apache.org/r/18734/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi


Re: Review Request 18734: Nagios, HIVE-METASTORE servicegroup is not correct, should be HIVE

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18734/#review36118
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 4, 2014, 5:15 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18734/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 5:15 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4936
>     https://issues.apache.org/jira/browse/AMBARI-4936
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ...
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh 3e4c61a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 233051f 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 5b56354 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh 0982606 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 a22f208 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 edc36c6 
>   contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php ddae4c0 
> 
> Diff: https://reviews.apache.org/r/18734/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 18734: Nagios, HIVE-METASTORE servicegroup is not correct, should be HIVE

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18734/#review36119
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On March 4, 2014, 12:15 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18734/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 12:15 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4936
>     https://issues.apache.org/jira/browse/AMBARI-4936
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ...
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh 3e4c61a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 233051f 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 5b56354 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh 0982606 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 a22f208 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 edc36c6 
>   contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php ddae4c0 
> 
> Diff: https://reviews.apache.org/r/18734/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 18734: Nagios, HIVE-METASTORE servicegroup is not correct, should be HIVE

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18734/
-----------------------------------------------------------

(Updated March 4, 2014, 5:15 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Changes
-------

changes in nagios_alerts.php done.


Bugs: AMBARI-4936
    https://issues.apache.org/jira/browse/AMBARI-4936


Repository: ambari


Description
-------

...


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh 3e4c61a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 233051f 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 5b56354 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh 0982606 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 a22f208 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 edc36c6 
  contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php ddae4c0 

Diff: https://reviews.apache.org/r/18734/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi


Re: Review Request 18734: Nagios, HIVE-METASTORE servicegroup is not correct, should be HIVE

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

> On March 4, 2014, 4:44 p.m., Nate Cole wrote:
> > Need also to modify contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php

It works w/o this changes, but it's good for more clear code.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18734/#review36114
-----------------------------------------------------------


On March 4, 2014, 5:15 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18734/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 5:15 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4936
>     https://issues.apache.org/jira/browse/AMBARI-4936
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ...
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh 3e4c61a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 233051f 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 5b56354 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh 0982606 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 a22f208 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 edc36c6 
>   contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php ddae4c0 
> 
> Diff: https://reviews.apache.org/r/18734/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 18734: Nagios, HIVE-METASTORE servicegroup is not correct, should be HIVE

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18734/#review36114
-----------------------------------------------------------


Need also to modify contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php

- Nate Cole


On March 4, 2014, 11:40 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18734/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 11:40 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4936
>     https://issues.apache.org/jira/browse/AMBARI-4936
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ...
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh 3e4c61a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 233051f 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 5b56354 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh 0982606 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 a22f208 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 edc36c6 
> 
> Diff: https://reviews.apache.org/r/18734/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>