[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #96: Integrate AWSS3IntegrationSpec with S3 Account

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #96:
URL: https://github.com/apache/incubator-pekko-connectors/pull/96#discussion_r1183329043


##########
s3/src/test/scala/org/apache/pekko/stream/connectors/s3/TestUtils.scala:
##########


Review Comment:
   These generators are directly copied from an OS company project (see https://github.com/aiven/guardian-for-apache-kafka/blob/main/core-s3/src/test/scala/io/aiven/guardian/kafka/s3/Generators.scala) and hence I can confirm that they work correctly since they have been use for over a year.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org