[GitHub] [solr] magibney commented on a diff in pull request #1279: SOLR-16613: CryptoKeys should handle RSA padding for OpenJ9

[GitBox <gi...@apache.org>]

magibney commented on code in PR #1279:
URL: https://github.com/apache/solr/pull/1279#discussion_r1063821975


##########
solr/core/src/java/org/apache/solr/util/CryptoKeys.java:
##########
@@ -295,15 +304,28 @@ public PublicKey getPublicKey() {
       return publicKey;
     }
 
-    public byte[] encrypt(ByteBuffer buffer) {

Review Comment:
   This is a public method on a public utility class though; I wonder if the intention was to have this used flexibly from elsewhere? This could in principle break plugin code ...
   
   This change seems good still, but worth explicitly calling out this possible concern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org