[GitHub] [tvm] Hzfengsy commented on a diff in pull request #14185: [Refactor] Move `VarUseDefAnalysis` to header file

["Hzfengsy (via GitHub)" <gi...@apache.org>]

Hzfengsy commented on code in PR #14185:
URL: https://github.com/apache/tvm/pull/14185#discussion_r1124305655


##########
include/tvm/tir/analysis.h:
##########
@@ -86,6 +87,58 @@ TVM_DLL double EstimateTIRFlops(const Stmt& stmt);
  */
 TVM_DLL double EstimateTIRFlops(const IRModule& mod);
 
+/*!
+ * \brief Visitor class to perform use/def analysis, also delete unreferenced lets.
+ * \sa UndefinedVars
+ */
+class VarUseDefAnalyzer : public StmtExprMutator {

Review Comment:
   Do we really need to move the mutator to the public header file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org