You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2005/02/07 16:58:55 UTC
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Wesley J. Landaker wrote:
> On Thu, 27 Jan 2005, Felix Wiemann wrote:
>> The word "revision" is not recognized in svn:keywords, but "Revision"
>> is. IMO it should be matched case-insensitively for consistency with
>> 'Author' or 'Date', shouldn't it?
>
> This seems like a good idea, since all the other "SHORT" forms are handled
> thus (and this is the only "MEDIUM" one). Here is a patch if the
> developer's agree as well. =)
>
> Log Message:
> * libsvn_subr/subst.c
> (svn_subst_build_keywords): Make "Revision" keyword case insensitve.
If no one objects, I'm going to apply this.
It's easy to think that "Revision" fits into the same set as "Author" and
"Date".
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by John Peacock <jp...@rowman.com>.
kfogel@collab.net wrote:
> Aren't they all case-sensitive in the working file, but
> case-insensitive in the property value?
>
See subst.c:translate_keyword_subst(), which uses strncmp() exclusively
when translating (hence you are correct that it is case-sensitive in the
working file). However, see subst.c:build_keywords(), which uses
strcmp() for the long and medium forms and strcasecmp() for the short forms.
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by kf...@collab.net.
"Peter N. Lundblad" <pe...@famlundblad.se> writes:
> Is there some special reason some keywords are case-sensitive, but other
> are not?
Aren't they all case-sensitive in the working file, but
case-insensitive in the property value?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by John Peacock <jp...@rowman.com>.
kfogel@collab.net wrote:
>
> Oooh... want to file an issue with this thread, and in particular with
> your mail? :-)
>
I hear and obey...
http://subversion.tigris.org/issues/show_bug.cgi?id=2219
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by kf...@collab.net.
John Peacock <jp...@rowman.com> writes:
> I wish I could say I could do this (since keywords seem to be my
> obsession), but my son (4 1/2) has stopped going to bed easily. The
> amount of brainpower I have to deal with programming issues is vastly
> reduced these days, and I still have the keywords-as-hash patch to
> finish up.
>
> Anyone wanting to do this [bite-sized task] should look at the
> following section of code (from subversion/libsvn_wc/props.c:1108):
>
> if (kind == svn_node_file && strcmp (name, SVN_PROP_KEYWORDS) == 0)
> SVN_ERR (svn_wc__get_keywords (&old_keywords, path, adm_access, NULL,
> pool));
>
> and extend that if into a block which parses the value into tokens and
> then matches the tokens against the legal keyword values (found in
> subversion/include/svn_types.h starting at 216). See the above block
> dealing with SVN_PROP_EXECUTABLE for hints on rewriting the string.
>
> My personal preference would be to expand the tokens to be the LONG
> variants, stored in alphabetical order, but that's just me (and I'm
> taking medication to help these impulses, really I am ;)...
Oooh... want to file an issue with this thread, and in particular with
your mail? :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by John Peacock <jp...@rowman.com>.
Max Bowsher wrote:
> I'd be happy with just canonicalizing the input - for example, you can
> set svn:executable to any value, and it is silently canonicalized. I
> would apply the same logic to svn:keywords, and fully canonicalize the
> values - including the whitespace, particular alias, and order, too.
> Essentially, parse the keywords value (permissively) and then rewrite
> the string from the parsed set of booleans.
This seems doable in svn_wc_prop_set2 and it would deal with both of our
concerns I think. You're happy because we aren't relying on inconsistent case
and I'm happy because the capitalization matches usage in the file. We still
can't twilight the case-insensitive matching code until a dump/load cycle (where
we could normalize all svn:keywords values), since we are only fixing up the
input, not any existing values.
I wish I could say I could do this (since keywords seem to be my obsession), but
my son (4 1/2) has stopped going to bed easily. The amount of brainpower I have
to deal with programming issues is vastly reduced these days, and I still have
the keywords-as-hash patch to finish up.
Anyone wanting to do this [bite-sized task] should look at the following section
of code (from subversion/libsvn_wc/props.c:1108):
if (kind == svn_node_file && strcmp (name, SVN_PROP_KEYWORDS) == 0)
SVN_ERR (svn_wc__get_keywords (&old_keywords, path, adm_access, NULL,
pool));
and extend that if into a block which parses the value into tokens and then
matches the tokens against the legal keyword values (found in
subversion/include/svn_types.h starting at 216). See the above block dealing
with SVN_PROP_EXECUTABLE for hints on rewriting the string.
My personal preference would be to expand the tokens to be the LONG variants,
stored in alphabetical order, but that's just me (and I'm taking medication to
help these impulses, really I am ;)...
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by Max Bowsher <ma...@ukf.net>.
kfogel@collab.net wrote:
> Have we already considered the possibility of disallowing the
> case-insensitive versions at propset/propedit time, starting now,
> while continuing to respond to them in expansion?
>
> I don't recall seeing that proposal on this thread, but it might solve
> most of the problem here...
>
> To be completely precise, what I'm proposing is:
>
> 1) Any words in an svn:keywords value that currently cause keyword
> expansion to happen, would continue to do so. This includes
> words that are case-variants of keywords (keywords which are
> themselves case-sensitive in the working file, of course).
>
> 2) At propset/propedit time, check the value of svn:keywords,
> disallowing case-variants -- all new incoming svn:keywords
> values would have to match the real keyword case.
>
> This would mean that if you have a legacy svn:keywords property:
>
> "author date id"
>
> and you attempt set/edit it to:
>
> "author date id Revision"
>
> ... there would be an error saying that all the keywords must match
> with exact case now. I'm not bothering to come up with the exact
> wording of that error right now, but maybe it could clarify the
> historical reasons behind the new behavior.
I'd be happy with just canonicalizing the input - for example, you can set
svn:executable to any value, and it is silently canonicalized. I would apply
the same logic to svn:keywords, and fully canonicalize the values -
including the whitespace, particular alias, and order, too.
Essentially, parse the keywords value (permissively) and then rewrite the
string from the parsed set of booleans.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by kf...@collab.net.
Have we already considered the possibility of disallowing the
case-insensitive versions at propset/propedit time, starting now,
while continuing to respond to them in expansion?
I don't recall seeing that proposal on this thread, but it might solve
most of the problem here...
To be completely precise, what I'm proposing is:
1) Any words in an svn:keywords value that currently cause keyword
expansion to happen, would continue to do so. This includes
words that are case-variants of keywords (keywords which are
themselves case-sensitive in the working file, of course).
2) At propset/propedit time, check the value of svn:keywords,
disallowing case-variants -- all new incoming svn:keywords
values would have to match the real keyword case.
This would mean that if you have a legacy svn:keywords property:
"author date id"
and you attempt set/edit it to:
"author date id Revision"
... there would be an error saying that all the keywords must match
with exact case now. I'm not bothering to come up with the exact
wording of that error right now, but maybe it could clarify the
historical reasons behind the new behavior.
-Karl
John Peacock <jp...@rowman.com> writes:
> 1) The keyword strings inside the files are currently case-sensitive
> (and I personally see no reason to change that now or ever).
>
> 2) The capitalization of the svn:keywords should match the actual
> keywords as appear in the file, for consistencies sake. There is no
> benefit to having the svn:keywords _not_ be case-sensitive (and it may
> even cause people to request breaking #1 for their
> laziness^Wconvenience).
>
> 3) We cannot take back the short versions being case-insensitive until
> a major release (at which point we could fix up the existing
> svn:keywords entries in the nigh inevitable dump/load cycle).
>
> 4) The case-insensitivity of the short versions is _not documented_
> anywhere (indeed the subject isn't covered at all in the book and it
> is only through experimentation that the user discovers that it _is_
> case-sensitive in the WC file).
>
> 5) Making all of the svn:keywords entries case-insensitive and then
> _documenting_ that removes a minor programmer visible inconsistency,
> but doesn't improve the experience for the user one iota, since they
> /still/ have to remember that inside the file all keywords _are_
> case-sensitive.
>
> Therefore, I don't think the relatively minor gratification of making
> the interface internally consistent is worth possibly limiting our
> actions in future releases. As I said, I don't have enough voltage to
> actually veto this (and I can see your point, really I can), but if
> you (Max) do go ahead and do this, I would suggest that any patch
> include the documentation and spell out exactly what promise we are
> now going to keep /vis a vis/ keyword capitalization, both in
> svn:keywords and in the files themselves.
>
> John
>
> --
> John Peacock
> Director of Information Research and Technology
> Rowman & Littlefield Publishing Group
> 4720 Boston Way
> Lanham, MD 20706
> 301-459-3366 x.5010
> fax 301-429-5747
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by John Peacock <jp...@rowman.com>.
Max Bowsher wrote:
> I like what you propose, but:
>
> 1) I'm not 100% sure we would get consensus that case-sensitivizing
> svn:keywords in 2.0 was worth the change - although I personally would +1.
My personal reasoning goes like this:
1) The keyword strings inside the files are currently case-sensitive (and I
personally see no reason to change that now or ever).
2) The capitalization of the svn:keywords should match the actual keywords as
appear in the file, for consistencies sake. There is no benefit to having the
svn:keywords _not_ be case-sensitive (and it may even cause people to request
breaking #1 for their laziness^Wconvenience).
3) We cannot take back the short versions being case-insensitive until a major
release (at which point we could fix up the existing svn:keywords entries in the
nigh inevitable dump/load cycle).
4) The case-insensitivity of the short versions is _not documented_ anywhere
(indeed the subject isn't covered at all in the book and it is only through
experimentation that the user discovers that it _is_ case-sensitive in the WC file).
5) Making all of the svn:keywords entries case-insensitive and then
_documenting_ that removes a minor programmer visible inconsistency, but doesn't
improve the experience for the user one iota, since they /still/ have to
remember that inside the file all keywords _are_ case-sensitive.
Therefore, I don't think the relatively minor gratification of making the
interface internally consistent is worth possibly limiting our actions in future
releases. As I said, I don't have enough voltage to actually veto this (and I
can see your point, really I can), but if you (Max) do go ahead and do this, I
would suggest that any patch include the documentation and spell out exactly
what promise we are now going to keep /vis a vis/ keyword capitalization, both
in svn:keywords and in the files themselves.
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by Max Bowsher <ma...@ukf.net>.
John Peacock wrote:
> Max Bowsher wrote:
>
>> What Peter said.
>> Since we can't be consistent, it's better to be consistently
>> inconsistent, rather than inconsistently inconsistent. :-)
>
> Except that you can't take this one back (as easily) for 2.0. I agree
> completely that it would be best if svn:keywords exactly matched what we
> support for keywords in the file.
>
> Rather than the smaller universe of people who used the short
> (case-insensitive) form in svn:keywords getting bitten in the move to
> 2.0 (with the completely rewritten keyword handling ;-), now you will
> bite many more people who got lazy and didn't care about capitalization
> when they set svn:keywords.
>
> I would rather change the documentation to say that the svn:keywords
> _should_ match the usage in the files, but not change the code to
> enforce that until 2.0.
>
> I'm still -0.5, but I don't strictly have a veto, so go ahead if you
> want (see if I care ;-)
I like what you propose, but:
1) I'm not 100% sure we would get consensus that case-sensitivizing
svn:keywords in 2.0 was worth the change - although I personally would +1.
2) I don't see universal case-insensitivity now as incompatible with that.
Since _some_ canonicalization would be necessary anyway, making svn:keywords
completely case-insensitive now is inconsequential.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by John Peacock <jp...@rowman.com>.
Max Bowsher wrote:
> What Peter said.
> Since we can't be consistent, it's better to be consistently
> inconsistent, rather than inconsistently inconsistent. :-)
Except that you can't take this one back (as easily) for 2.0. I agree
completely that it would be best if svn:keywords exactly matched what we
support for keywords in the file.
Rather than the smaller universe of people who used the short
(case-insensitive) form in svn:keywords getting bitten in the move to
2.0 (with the completely rewritten keyword handling ;-), now you will
bite many more people who got lazy and didn't care about capitalization
when they set svn:keywords.
I would rather change the documentation to say that the svn:keywords
_should_ match the usage in the files, but not change the code to
enforce that until 2.0.
I'm still -0.5, but I don't strictly have a veto, so go ahead if you
want (see if I care ;-)
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by Max Bowsher <ma...@ukf.net>.
Peter N. Lundblad wrote:
> On Mon, 7 Feb 2005, John Peacock wrote:
>
>> Max Bowsher wrote:
>>
>>>
>>> It's consistent, and no less unpleasant than having some
>>> case-insensitive.
>>>
>>> +1.
>>>
>>> I'll do it in a few hours.
>>
>> Except that then it is _inconsistent_ with the behavior of the working
>> copy file, see translate_keyword() and the calls that makes to
>> translate_keyword_subst().
>>
>> -1 (as it currently has been discussed)
>>
> But it is already inconsistent. Wouldn't it be better to be consistently
> inconsistent? We can't make it case-sensitive in svn:keywords (which would
> have been the obvious choice). If we do the proposed change, we can at
> least document "svn:keywords case-insensitive, in the file:
> case-sensitive". Currenlty we have a difference between long and short
> forms, which I find confusing.
What Peter said.
Since we can't be consistent, it's better to be consistently inconsistent,
rather than inconsistently inconsistent. :-)
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 7 Feb 2005, John Peacock wrote:
> Max Bowsher wrote:
>
> >
> > It's consistent, and no less unpleasant than having some case-insensitive.
> >
> > +1.
> >
> > I'll do it in a few hours.
>
> Except that then it is _inconsistent_ with the behavior of the working
> copy file, see translate_keyword() and the calls that makes to
> translate_keyword_subst().
>
> -1 (as it currently has been discussed)
>
But it is already inconsistent. Wouldn't it be better to be consistently
inconsistent? We can't make it case-sensitive in svn:keywords (which would
have been the obvious choice). If we do the proposed change, we can at
least document "svn:keywords case-insensitive, in the file:
case-sensitive". Currenlty we have a difference between long and short
forms, which I find confusing.
OK, it's no hot topic, so I'll stop now and go back to more important
things.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by kf...@collab.net.
"Max Bowsher" <ma...@ukf.net> writes:
> > I'm a bit confused. Isn't Max proposing to make all the property
> > values case-insensitive, instead of just some of them?
>
> Correct.
>
> > This is
> > completely backwards compatible, and it has no effect on the
> > case-sensitivity of keywords in the working file.
>
> Also correct.
>
> > Is that what you're vetoing? Or if are you vetoing something else, is
> > it the same as what Max is proposing?
>
> He dislikes that svn:keywords is case-insensitive (partly) whilst the
> file itself is case-sensitive.
>
> But see my other recent email for more detail.
I get it now, thanks.
I think I'm left supporting the status quo, so I'll say no more.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by Max Bowsher <ma...@ukf.net>.
kfogel@collab.net wrote:
> John Peacock <jp...@rowman.com> writes:
>> Max Bowsher wrote:
>>> It's consistent, and no less unpleasant than having some
>>> case-insensitive.
>>> +1.
>>> I'll do it in a few hours.
>>
>> Except that then it is _inconsistent_ with the behavior of the working
>> copy file, see translate_keyword() and the calls that makes to
>> translate_keyword_subst().
>>
>> -1 (as it currently has been discussed)
>
> Wait, what?
>
> I'm a bit confused. Isn't Max proposing to make all the property
> values case-insensitive, instead of just some of them?
Correct.
> This is
> completely backwards compatible, and it has no effect on the
> case-sensitivity of keywords in the working file.
Also correct.
> Is that what you're vetoing? Or if are you vetoing something else, is
> it the same as what Max is proposing?
He dislikes that svn:keywords is case-insensitive (partly) whilst the file
itself is case-sensitive.
But see my other recent email for more detail.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by kf...@collab.net.
John Peacock <jp...@rowman.com> writes:
> Max Bowsher wrote:
> > It's consistent, and no less unpleasant than having some
> > case-insensitive.
> > +1.
> > I'll do it in a few hours.
>
> Except that then it is _inconsistent_ with the behavior of the working
> copy file, see translate_keyword() and the calls that makes to
> translate_keyword_subst().
>
> -1 (as it currently has been discussed)
Wait, what?
I'm a bit confused. Isn't Max proposing to make all the property
values case-insensitive, instead of just some of them? This is
completely backwards compatible, and it has no effect on the
case-sensitivity of keywords in the working file.
Is that what you're vetoing? Or if are you vetoing something else, is
it the same as what Max is proposing?
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by John Peacock <jp...@rowman.com>.
Max Bowsher wrote:
>
> It's consistent, and no less unpleasant than having some case-insensitive.
>
> +1.
>
> I'll do it in a few hours.
Except that then it is _inconsistent_ with the behavior of the working
copy file, see translate_keyword() and the calls that makes to
translate_keyword_subst().
-1 (as it currently has been discussed)
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by Max Bowsher <ma...@ukf.net>.
Peter N. Lundblad wrote:
> On Mon, 7 Feb 2005, Max Bowsher wrote:
>
>> Peter N. Lundblad wrote:
>>> On Mon, 7 Feb 2005, Max Bowsher wrote:
>>>
>>> Is there some special reason some keywords are case-sensitive, but other
>>> are not?
>>
>> Not to my knowledge.
>>
>> Personally, I'd prefer that svn:keywords was entirely case-sensitive,
>> just
>> like the actual substitutions. However, it's a bit late for that now.
>>
>> The scheme seems to be LONG == case-sensitive, SHORT == case-insensitive.
>> Since "Revision", whilst being MEDIUM and thus a grey area, is similar to
>> "Date", "Author", etc., i.e. the SHORT keywords, I think it should follow
>> their pattern, and be case-insensitive.
>>
> This mix is just confusing. I'd say, just make them all case-insensitive
> in the svn:keywords.
It's consistent, and no less unpleasant than having some case-insensitive.
+1.
I'll do it in a few hours.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 7 Feb 2005, Max Bowsher wrote:
> Peter N. Lundblad wrote:
> > On Mon, 7 Feb 2005, Max Bowsher wrote:
> >
> > Is there some special reason some keywords are case-sensitive, but other
> > are not?
>
> Not to my knowledge.
>
> Personally, I'd prefer that svn:keywords was entirely case-sensitive, just
> like the actual substitutions. However, it's a bit late for that now.
>
> The scheme seems to be LONG == case-sensitive, SHORT == case-insensitive.
> Since "Revision", whilst being MEDIUM and thus a grey area, is similar to
> "Date", "Author", etc., i.e. the SHORT keywords, I think it should follow
> their pattern, and be case-insensitive.
>
This mix is just confusing. I'd say, just make them all case-insensitive
in the svn:keywords.
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by Max Bowsher <ma...@ukf.net>.
Peter N. Lundblad wrote:
> On Mon, 7 Feb 2005, Max Bowsher wrote:
>
>> Wesley J. Landaker wrote:
>>> On Thu, 27 Jan 2005, Felix Wiemann wrote:
>>>> The word "revision" is not recognized in svn:keywords, but "Revision"
>>>> is. IMO it should be matched case-insensitively for consistency with
>>>> 'Author' or 'Date', shouldn't it?
>>>
>>> This seems like a good idea, since all the other "SHORT" forms are
>>> handled
>>> thus (and this is the only "MEDIUM" one). Here is a patch if the
>>> developer's agree as well. =)
>>>
>>> Log Message:
>>> * libsvn_subr/subst.c
>>> (svn_subst_build_keywords): Make "Revision" keyword case insensitve.
>>
>>
>> If no one objects, I'm going to apply this.
>
> Is there some special reason some keywords are case-sensitive, but other
> are not?
Not to my knowledge.
Personally, I'd prefer that svn:keywords was entirely case-sensitive, just
like the actual substitutions. However, it's a bit late for that now.
The scheme seems to be LONG == case-sensitive, SHORT == case-insensitive.
Since "Revision", whilst being MEDIUM and thus a grey area, is similar to
"Date", "Author", etc., i.e. the SHORT keywords, I think it should follow
their pattern, and be case-insensitive.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 7 Feb 2005, Max Bowsher wrote:
> Wesley J. Landaker wrote:
> > On Thu, 27 Jan 2005, Felix Wiemann wrote:
> >> The word "revision" is not recognized in svn:keywords, but "Revision"
> >> is. IMO it should be matched case-insensitively for consistency with
> >> 'Author' or 'Date', shouldn't it?
> >
> > This seems like a good idea, since all the other "SHORT" forms are handled
> > thus (and this is the only "MEDIUM" one). Here is a patch if the
> > developer's agree as well. =)
> >
> > Log Message:
> > * libsvn_subr/subst.c
> > (svn_subst_build_keywords): Make "Revision" keyword case insensitve.
>
>
> If no one objects, I'm going to apply this.
Is there some special reason some keywords are case-sensitive, but other
are not?
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org