You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by qiao wen <31...@qq.com> on 2018/07/12 01:33:00 UTC

Re: Review Request 50378: FLUME-2960: Support Wildcards in directoryname in TaildirSource

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50378/
-----------------------------------------------------------

(Updated July 12, 2018, 1:32 a.m.)


Review request for Flume.


Changes
-------

Fix one code style problem.


Repository: flume-git


Description
-------

In our log management project, we wan't to track many log files like this:
/app/dir1/log.*
/app/dir2/log.*
...
/app/dirn/log.*
But TaildirSource can't support wildcards in filegroup directory name. The following config is expected:
a1.sources.r1.filegroups.fg = /app/*/log.*


Diffs (updated)
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst a4e08186 
  flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 633d3c19 
  flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java ad9f7201 
  flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java a107a017 
  flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java f2347f38 
  flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirEventReader.java e75543c7 
  flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java c3410548 
  flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java 097ee0ba 


Diff: https://reviews.apache.org/r/50378/diff/8/

Changes: https://reviews.apache.org/r/50378/diff/7-8/


Testing
-------

All tests in TestTaildirSource passed.


Thanks,

qiao wen