[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11518: [fix][issues-11517] cannot select project when create depend task

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #11518:
URL: https://github.com/apache/dolphinscheduler/pull/11518#discussion_r947420412


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.xml:
##########
@@ -167,8 +167,8 @@
         </include>
         from t_ds_project p
         <if test="userId != 0">
-            right join t_ds_relation_project_user rpu on p.id = rpu.project_id
-            where rpu.user_id = #{userId}
+            left join t_ds_relation_project_user rpu on p.id = rpu.project_id
+            where rpu.user_id = #{userId} or p.user_id=#{userId}

Review Comment:
   I think ordinary user should not be allowed to query its project before it's authorized.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org