You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/05/06 22:00:30 UTC

[GitHub] [incubator-mxnet] mseth10 opened a new pull request #20252: [WIP] Add aarch64 support

mseth10 opened a new pull request #20252:
URL: https://github.com/apache/incubator-mxnet/pull/20252


   ## Description ##
   Adds AArch64 build support in MXNet with a native-compilation toolchain. Adds the following files:
   - ci/docker/Dockerfile.publish.ubuntu1804_aarch64_cpu - CD dockerfile used while building MXNet 
   -  ci/docker/install/ubuntu_aarch64_publish.sh - Installs build dependencies used by above dockerfile
   - config/distribution/linux_aarch64_cpu.cmake - config file defining MXNet build flags
   - tools/* - update build scripts for aarch64 support
   
   ## Comments ##
   - Dockerfile and build scripts have been tested locally
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #20252: [WIP] Add aarch64 support

Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #20252:
URL: https://github.com/apache/incubator-mxnet/pull/20252#discussion_r630685455



##########
File path: tools/staticbuild/build_lib_cmake.sh
##########
@@ -39,14 +44,18 @@ rm -rf lib; mkdir lib;
 if [[ $PLATFORM == 'linux' ]]; then
     cp -L build/libmxnet.so lib/libmxnet.so
     cp -L staticdeps/lib/libopenblas.so lib/libopenblas.so.0
-    if [[ -f /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so ]]; then
-        cp -L /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so lib/libgfortran.so.3
-    elif [[ -f /usr/lib/x86_64-linux-gnu/libgfortran.so.3 ]]; then
-        cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.3 lib/libgfortran.so.3
+    if [[ $ARCH == 'aarch64' ]]; then
+        cp -L /usr/lib/aarch64-linux-gnu/libgfortran.so.5 lib/libgfortran.so.5
     else
-        cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.4 lib/libgfortran.so.4
+        if [[ -f /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so ]]; then
+            cp -L /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so lib/libgfortran.so.3
+        elif [[ -f /usr/lib/x86_64-linux-gnu/libgfortran.so.3 ]]; then
+            cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.3 lib/libgfortran.so.3
+        else
+            cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.4 lib/libgfortran.so.4
+        fi
+        cp -L /usr/lib/x86_64-linux-gnu/libquadmath.so.0 lib/libquadmath.so.0

Review comment:
       addressed

##########
File path: tools/staticbuild/build_lib_cmake.sh
##########
@@ -39,14 +44,18 @@ rm -rf lib; mkdir lib;
 if [[ $PLATFORM == 'linux' ]]; then
     cp -L build/libmxnet.so lib/libmxnet.so
     cp -L staticdeps/lib/libopenblas.so lib/libopenblas.so.0
-    if [[ -f /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so ]]; then
-        cp -L /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so lib/libgfortran.so.3
-    elif [[ -f /usr/lib/x86_64-linux-gnu/libgfortran.so.3 ]]; then
-        cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.3 lib/libgfortran.so.3
+    if [[ $ARCH == 'aarch64' ]]; then
+        cp -L /usr/lib/aarch64-linux-gnu/libgfortran.so.5 lib/libgfortran.so.5

Review comment:
       addressed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mseth10 merged pull request #20252: [v1.x] Add aarch64 support

Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #20252:
URL: https://github.com/apache/incubator-mxnet/pull/20252


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20252: [WIP] Add aarch64 support

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20252:
URL: https://github.com/apache/incubator-mxnet/pull/20252#discussion_r627828035



##########
File path: tools/staticbuild/build_lib_cmake.sh
##########
@@ -39,14 +44,18 @@ rm -rf lib; mkdir lib;
 if [[ $PLATFORM == 'linux' ]]; then
     cp -L build/libmxnet.so lib/libmxnet.so
     cp -L staticdeps/lib/libopenblas.so lib/libopenblas.so.0
-    if [[ -f /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so ]]; then
-        cp -L /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so lib/libgfortran.so.3
-    elif [[ -f /usr/lib/x86_64-linux-gnu/libgfortran.so.3 ]]; then
-        cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.3 lib/libgfortran.so.3
+    if [[ $ARCH == 'aarch64' ]]; then
+        cp -L /usr/lib/aarch64-linux-gnu/libgfortran.so.5 lib/libgfortran.so.5
     else
-        cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.4 lib/libgfortran.so.4
+        if [[ -f /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so ]]; then
+            cp -L /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so lib/libgfortran.so.3
+        elif [[ -f /usr/lib/x86_64-linux-gnu/libgfortran.so.3 ]]; then
+            cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.3 lib/libgfortran.so.3
+        else
+            cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.4 lib/libgfortran.so.4
+        fi
+        cp -L /usr/lib/x86_64-linux-gnu/libquadmath.so.0 lib/libquadmath.so.0

Review comment:
       lib/libquadmath.so.0 should not be copied due to licensing issues https://github.com/apache/incubator-mxnet/pull/19053/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20252: [WIP] Add aarch64 support

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20252:
URL: https://github.com/apache/incubator-mxnet/pull/20252#discussion_r627828497



##########
File path: tools/staticbuild/build_lib_cmake.sh
##########
@@ -39,14 +44,18 @@ rm -rf lib; mkdir lib;
 if [[ $PLATFORM == 'linux' ]]; then
     cp -L build/libmxnet.so lib/libmxnet.so
     cp -L staticdeps/lib/libopenblas.so lib/libopenblas.so.0
-    if [[ -f /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so ]]; then
-        cp -L /usr/lib/gcc/x86_64-linux-gnu/4.8/libgfortran.so lib/libgfortran.so.3
-    elif [[ -f /usr/lib/x86_64-linux-gnu/libgfortran.so.3 ]]; then
-        cp -L /usr/lib/x86_64-linux-gnu/libgfortran.so.3 lib/libgfortran.so.3
+    if [[ $ARCH == 'aarch64' ]]; then
+        cp -L /usr/lib/aarch64-linux-gnu/libgfortran.so.5 lib/libgfortran.so.5

Review comment:
       Have you tried the one-liner `cp -L $(ldd lib/libmxnet.so | grep libgfortran |  awk '{print $3}') lib/` from master branch? It may be easier to maintain




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20252: [WIP] Add aarch64 support

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20252:
URL: https://github.com/apache/incubator-mxnet/pull/20252#issuecomment-833898747


   Hey @mseth10 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [miscellaneous, sanity, clang, unix-cpu, unix-gpu, centos-gpu, windows-gpu, windows-cpu, centos-cpu, website, edge]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org