[Bug 4034] Conf parser can throw warnings for invalid rules

[bu...@bugzilla.spamassassin.org]

http://bugzilla.spamassassin.org/show_bug.cgi?id=4034

felicity@kluge.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major
           Priority|P5                          |P3
            Summary|Upgrade from 2.6 to 3.0     |Conf parser can throw
                   |fails                       |warnings for invalid rules
   Target Milestone|Future                      |3.0.3



------- Additional Comments From felicity@kluge.net  2004-12-16 10:39 -------
In a quick look around Conf.pm, the issue seems to be that rules that aren't evals aren't checked for 
syntax errors before calling add_test() which fails horribly if no actual RE is given.  All rule types seem 
affected.  (rawbody, full, meta, header, etc.)

BTW, the reason is split doesn't generate empty values if the split fails:

        $self->{parser}->add_test (split(/\s+/,$value,2), $TYPE_RAWBODY_TESTS);

so if $value is "FOO", only ("FOO") comes out, not ("FOO", undef) ...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.