You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2011/07/20 00:28:58 UTC
[jira] [Created] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Comment clause should immediately follow identifier field in CREATE DATABASE statement
--------------------------------------------------------------------------------------
Key: HIVE-2292
URL: https://issues.apache.org/jira/browse/HIVE-2292
Project: Hive
Issue Type: Bug
Components: SQL
Reporter: Carl Steinbach
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073548#comment-13073548 ]
Hudson commented on HIVE-2292:
------------------------------
Integrated in Hive-trunk-h0.21 #863 (See [https://builds.apache.org/job/Hive-trunk-h0.21/863/])
HIVE-2292. Comment clause should immediately follow identifier field in CREATE DATABASE statement. Contributed by Carl Steinbach
amareshwari : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152709
Files :
* /hive/trunk/ql/src/test/results/clientpositive/database_location.q.out
* /hive/trunk/ql/src/test/queries/clientpositive/database_location.q
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.8.0
>
> Attachments: HIVE-2292.1.patch.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach reassigned HIVE-2292:
------------------------------------
Assignee: Carl Steinbach
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.8.0
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2292:
---------------------------------
Fix Version/s: 0.8.0
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Fix For: 0.8.0
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2292:
---------------------------------
Attachment: HIVE-2292.1.patch.txt
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.8.0
>
> Attachments: HIVE-2292.1.patch.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2292:
---------------------------------
Status: Patch Available (was: Open)
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.8.0
>
> Attachments: HIVE-2292.1.patch.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HIVE-2292:
------------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Carl !
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.8.0
>
> Attachments: HIVE-2292.1.patch.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073435#comment-13073435 ]
Amareshwari Sriramadasu commented on HIVE-2292:
-----------------------------------------------
Running tests with patch, HIVE-2292.1.patch.txt. Will commit once tests pass.
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.8.0
>
> Attachments: HIVE-2292.1.patch.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068052#comment-13068052 ]
Carl Steinbach commented on HIVE-2292:
--------------------------------------
HIVE-1537 added an optional LOCATION clause to the CREATE DATABASE statement, but the ordering of the COMMENT and LOCATION clauses is not consistent with the CREATE TABLE and CREATE VIEW statements:
{code}
CREATE DATABASE [IF NOT EXISTS] db_name
[LOCATION hdfs_path]
[COMMENT comment]
...
CREATE TABLE [IF NOT EXISTS] tb_name
[COMMENT comment]
...
[LOCATION hdfs_path]
CREATE VIEW [IF NOT EXISTS] vw_name
[COMMENT]
...
{code}
The syntax of the CREATE DATABASE statement should be modified so that the COMMENT clause immediately follows the db_name field.
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Fix For: 0.8.0
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069675#comment-13069675 ]
jiraposter@reviews.apache.org commented on HIVE-2292:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1186/
-----------------------------------------------------------
Review request for hive.
Summary
-------
Review for HIVE-2292.
This addresses bug HIVE-2292.
https://issues.apache.org/jira/browse/HIVE-2292
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 3a6d0a6
ql/src/test/queries/clientpositive/database_location.q ac8687f
ql/src/test/results/clientpositive/database_location.q.out a09f5a2
Diff: https://reviews.apache.org/r/1186/diff
Testing
-------
Thanks,
Carl
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.8.0
>
> Attachments: HIVE-2292.1.patch.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2292) Comment clause should immediately
follow identifier field in CREATE DATABASE statement
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073436#comment-13073436 ]
jiraposter@reviews.apache.org commented on HIVE-2292:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1186/#review1245
-----------------------------------------------------------
Ship it!
+1
- Amareshwari
On 2011-07-22 18:52:07, Carl Steinbach wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1186/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-22 18:52:07)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review for HIVE-2292.
bq.
bq.
bq. This addresses bug HIVE-2292.
bq. https://issues.apache.org/jira/browse/HIVE-2292
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 3a6d0a6
bq. ql/src/test/queries/clientpositive/database_location.q ac8687f
bq. ql/src/test/results/clientpositive/database_location.q.out a09f5a2
bq.
bq. Diff: https://reviews.apache.org/r/1186/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Carl
bq.
bq.
> Comment clause should immediately follow identifier field in CREATE DATABASE statement
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2292
> URL: https://issues.apache.org/jira/browse/HIVE-2292
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.8.0
>
> Attachments: HIVE-2292.1.patch.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira