[GitHub] [spark] MaxGekk commented on a change in pull request #28016: [SPARK-31238][SQL] Rebase dates to/from Julian calendar in write/read for ORC datasource

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #28016: [SPARK-31238][SQL] Rebase dates to/from Julian calendar in write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#discussion_r398070826
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DaysWritable.scala
 ##########
 @@ -35,11 +35,12 @@ import org.apache.spark.sql.catalyst.util.DateTimeUtils.{rebaseGregorianToJulian
  * @param julianDays The number of days since the epoch 1970-01-01 in
  *                   Julian calendar.
  */
-private[hive] class DaysWritable(
+class DaysWritable(
     var gregorianDays: Int,
     var julianDays: Int)
   extends DateWritable {
 
+  def this() = this(0, 0)
 
 Review comment:
   I assume that `gregorianDays` and `julianDays` will be set later via the `set` method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org