[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1267: [CELEBORN-332] Unify the log of ShuffleClientImpl

["AngersZhuuuu (via GitHub)" <gi...@apache.org>]

AngersZhuuuu commented on code in PR #1267:
URL: https://github.com/apache/incubator-celeborn/pull/1267#discussion_r1116471782


##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -187,11 +187,34 @@ private void submitRetryPushData(
           new CelebornIOException("Revive Failed, remain revive times " + remainReviveTimes));
     } else if (mapperEnded(shuffleId, mapId, attemptId)) {
       logger.debug(
-          "Retrying push data, but the mapper(map {} attempt {}) has ended.", mapId, attemptId);
+          "Revive for push data success, but the mapper already ended for shuffle "

Review Comment:
   > let's use the "{}" style, as we discussed.
   
   How about current?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org