You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/10 06:25:01 UTC

[GitHub] [pulsar] zymap opened a new pull request #7228: Protobuf-shaeded package can not udpate version

zymap opened a new pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228


   ---
   
   *Motivation*
   
   Using `set-project-version.sh` always failed with updating
   protobuf-shaded parent version.
   
   error log:
   
   ```
   [INFO] Scanning for projects...
   [ERROR] [ERROR] Some problems were encountered while processing the POMs:
   [FATAL] Non-resolvable parent POM for org.apache.pulsar:protobuf-shaded:2.6.0-SNAPSHOT: Could not find artifact org.apache.pulsar:pulsar:pom:2.6.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 26, column 11
    @
    [ERROR] The build could not read 1 project > [Help 1]
    [ERROR]
    [ERROR]   The project org.apache.pulsar:protobuf-shaded:2.6.0-SNAPSHOT (/home/zhangyong/actions-runner/_work/streamnative-ci/streamnative-ci/pulsar/protobuf-shaded/pom.xml) has 1 error
    [ERROR]     Non-resolvable parent POM for org.apache.pulsar:protobuf-shaded:2.6.0-SNAPSHOT: Could not find artifact org.apache.pulsar:pulsar:pom:2.6.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 26, column 11 > [Help 2]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException-''-''
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat merged pull request #7228: Protobuf-shaded package can not update version

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] zymap closed pull request #7228: Protobuf-shaded package can not update version

Posted by GitBox <gi...@apache.org>.
zymap closed pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] zymap commented on pull request #7228: Protobuf-shaded package can not update version

Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228#issuecomment-642049984


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] wolfstudy commented on pull request #7228: Protobuf-shaded package can not update version

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228#issuecomment-718349809


   need to cherry-pick 2.6.2.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat commented on a change in pull request #7228: Protobuf-shaded package can not update version

Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228#discussion_r438286491



##########
File path: src/set-project-version.sh
##########
@@ -30,12 +30,13 @@ NEW_VERSION=$1
 # Go to top level project directory
 pushd $(dirname "$0")/..
 
+# Get the current version
+OLD_VERSION=`mvn -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec`

Review comment:
       There's already a script that we use in multiple places to get the version: `./src/get-project-version.py`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] zymap commented on a change in pull request #7228: Protobuf-shaded package can not update version

Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228#discussion_r438512883



##########
File path: src/set-project-version.sh
##########
@@ -30,12 +30,13 @@ NEW_VERSION=$1
 # Go to top level project directory
 pushd $(dirname "$0")/..
 
+# Get the current version
+OLD_VERSION=`mvn -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec`

Review comment:
       Thanks for reminding me. I change to use the script to get the version. PTAL. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] zymap commented on pull request #7228: Protobuf-shaded package can not update version

Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228#issuecomment-642415049


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org