You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lianetm (via GitHub)" <gi...@apache.org> on 2026/03/11 23:01:20 UTC
[PR] KAFKA-20296: Fix flaky consumer metrics test [kafka]
lianetm opened a new pull request, #21713:
URL: https://github.com/apache/kafka/pull/21713
It has been flaky on trunk and PRs, failing when it continues to find a metric that is supposed to the removed when preparing fetch requests.
The metric is only removed when sending new fetch requests (on prepareFetchRequests), but the test was just waiting for a rebalance (callbacks triggered) , which really does not guarantee that we prepared a new fetch request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20296: Fix flaky consumer metrics test [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #21713:
URL: https://github.com/apache/kafka/pull/21713#issuecomment-4048023313
Thank you both for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20296: Fix flaky consumer metrics test [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm merged PR #21713:
URL: https://github.com/apache/kafka/pull/21713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20296: Fix flaky consumer metrics test [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #21713:
URL: https://github.com/apache/kafka/pull/21713#issuecomment-4045174738
> This fix makes sense for testPerPartitionLeadMetricsCleanUpWithSubscribe. Should we also update testPerPartitionLagMetricsCleanUpWithSubscribe in the same way?
I think that it probably should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org