You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by hustjl22 <gi...@git.apache.org> on 2014/09/10 22:32:07 UTC
[GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table Propertie...
GitHub user hustjl22 opened a pull request:
https://github.com/apache/accumulo/pull/15
ACCUMULO-2841 Add Arbitrary Table Properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hustjl22/accumulo ACCUMULO-2841
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit e2ff4bfdb35ee621188c045bc63c280f965b15a1
Author: Jenna Huston <je...@gmail.com>
Date: 2014-09-10T19:32:44Z
ACCUMULO-2841 Add Arbitrary Table Properties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table Propertie...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/15#discussion_r17387225
--- Diff: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java ---
@@ -430,6 +430,21 @@ void rename(String oldTableName, String newTableName) throws AccumuloSecurityExc
* if the table does not exist
*/
Iterable<Entry<String,String>> getProperties(String tableName) throws AccumuloException, TableNotFoundException;
+
+ /**
+ * Gets a specific property given its key. Note that recently changed properties may not be available immediately.
+ *
+ * @param tableName
+ * the name of the table
+ * @param property
+ * the name of a per-table property
+ * @throws TableNotFoundException
+ * if the table does not exist
+ * @throws AccumuloException
+ * if a general error occurs *
+ * @return value of the specified property, null if property does not exist
+ */
+ String getProperty(String tableName, String property)throws AccumuloException, TableNotFoundException;
--- End diff --
This API change can be part of a separate issue. Now that you've pointed it out, it seems like an obvious oversight in our API (who wants to iterate over an iterable to get one property?), but it is probably outside the scope of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table Propertie...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the pull request:
https://github.com/apache/accumulo/pull/15#issuecomment-55450146
Patch was applied in 6eedd1f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table Propertie...
Posted by hustjl22 <gi...@git.apache.org>.
Github user hustjl22 closed the pull request at:
https://github.com/apache/accumulo/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table Propertie...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/15#discussion_r17387391
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -345,6 +345,8 @@
+ "in zookeeper. Restarting accumulo tablet servers after setting these properties in the site file "
+ "will cause the global setting to take effect. However, you must use the API or the shell to change "
+ "properties in zookeeper that are set on a table."),
+ //Add prefix for arbitrary table properties
--- End diff --
Comment is not necessary. The enum description field should suffice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table Propertie...
Posted by Christopher <ct...@apache.org>.
It seems that no message is sent to the dev@ list when the pull request is
updated. Anybody know how to correct this? Is this an INFRA thing? Or a
GitHub quirk?
--
Christopher L Tubbs II
http://gravatar.com/ctubbsii
On Wed, Sep 10, 2014 at 4:59 PM, ctubbsii <gi...@git.apache.org> wrote:
> Github user ctubbsii commented on the pull request:
>
> https://github.com/apache/accumulo/pull/15#issuecomment-55182136
>
> Please (re-)apply the formatter on the changed files, to ensure that
> there's no trailing whitespace and such. I saw a few that stood out in the
> command-line git colored output (not sure why the GitHub interface doesn't
> highlight them, though). Thanks!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table Propertie...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the pull request:
https://github.com/apache/accumulo/pull/15#issuecomment-55182136
Please (re-)apply the formatter on the changed files, to ensure that there's no trailing whitespace and such. I saw a few that stood out in the command-line git colored output (not sure why the GitHub interface doesn't highlight them, though). Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table Propertie...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/15#discussion_r17387412
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -697,9 +699,10 @@ public synchronized static boolean isValidTablePropertyKey(String key) {
}
}
+ //Add the arbitrary table property prefix to the list of valid prefixes
--- End diff --
Comment not necessary. It seems to apply to the commit, rather than the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---