You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2018/01/04 15:50:43 UTC
[GitHub] nifi pull request #2370: NIFI-4733: Addressing two phase commit logic issue ...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2370
NIFI-4733: Addressing two phase commit logic issue in variable registry
NIFI-4733:
- Resolving logic issue in two phase commit when updating variable registry.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-4733
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2370.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2370
----
commit 284a9899cf8ee5734624d4136ac1c139f8e97b36
Author: Matt Gilman <ma...@...>
Date: 2018-01-03T16:00:22Z
NIFI-4733:
- Resolving logic issue in two phase commit when updating variable registry.
----
---
[GitHub] nifi issue #2370: NIFI-4733: Addressing two phase commit logic issue in vari...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2370
I ran a cluster with the patch applied and ensured no regressions on the two phase commit. Once the minor fixes are done, I can merge, but I'll leave the pre-emptive +1 here in case I am away from my computer.
Ran `contrib-check` and all tests pass. +1.
---
[GitHub] nifi pull request #2370: NIFI-4733: Addressing two phase commit logic issue ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2370
---
[GitHub] nifi pull request #2370: NIFI-4733: Addressing two phase commit logic issue ...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2370#discussion_r159700083
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java ---
@@ -552,41 +553,43 @@ public Response deleteVariableRegistryUpdateRequest(
public Response updateVariableRegistry(
@Context final HttpServletRequest httpServletRequest,
@ApiParam(value = "The process group id.", required = true) @PathParam("id") final String groupId,
- @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestEntity) {
+ @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestVariableRegistryEntity) {
--- End diff --
Should the `ApiParam` value be updated to reflect that this is VR-specific as opposed to generic PG configuration?
---
[GitHub] nifi pull request #2370: NIFI-4733: Addressing two phase commit logic issue ...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2370#discussion_r159703818
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java ---
@@ -620,13 +623,13 @@ public Response updateVariableRegistry(
public Response submitUpdateVariableRegistryRequest(
@Context final HttpServletRequest httpServletRequest,
@ApiParam(value = "The process group id.", required = true) @PathParam("id") final String groupId,
- @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestEntity) {
+ @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestVariableRegistryEntity) {
--- End diff --
Yup.
---
[GitHub] nifi pull request #2370: NIFI-4733: Addressing two phase commit logic issue ...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2370#discussion_r159700591
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java ---
@@ -552,41 +553,43 @@ public Response deleteVariableRegistryUpdateRequest(
public Response updateVariableRegistry(
@Context final HttpServletRequest httpServletRequest,
@ApiParam(value = "The process group id.", required = true) @PathParam("id") final String groupId,
- @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestEntity) {
+ @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestVariableRegistryEntity) {
--- End diff --
Yes good catch.
---
[GitHub] nifi pull request #2370: NIFI-4733: Addressing two phase commit logic issue ...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2370#discussion_r159703442
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java ---
@@ -620,13 +623,13 @@ public Response updateVariableRegistry(
public Response submitUpdateVariableRegistryRequest(
@Context final HttpServletRequest httpServletRequest,
@ApiParam(value = "The process group id.", required = true) @PathParam("id") final String groupId,
- @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestEntity) {
+ @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestVariableRegistryEntity) {
--- End diff --
Probably here too, then.
---
[GitHub] nifi issue #2370: NIFI-4733: Addressing two phase commit logic issue in vari...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2370
Thanks @alopresto! I've addressed the comments here and I will merge to master.
---
[GitHub] nifi issue #2370: NIFI-4733: Addressing two phase commit logic issue in vari...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2370
Reviewing...
---