You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2015/06/16 05:19:41 UTC
[1/5] trafficserver git commit: TS-3282: Initilaize variable per
clang-analyzer
Repository: trafficserver
Updated Branches:
refs/heads/master 146d7e168 -> 5174c55d0
TS-3282: Initilaize variable per clang-analyzer
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a620d329
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a620d329
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a620d329
Branch: refs/heads/master
Commit: a620d329c71c16cba493f6a83dd2435a199c8983
Parents: 146d7e1
Author: Phil Sorber <so...@apache.org>
Authored: Mon Jun 15 21:13:35 2015 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Mon Jun 15 21:17:48 2015 -0600
----------------------------------------------------------------------
plugins/experimental/mp4/mp4_meta.cc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a620d329/plugins/experimental/mp4/mp4_meta.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/mp4/mp4_meta.cc b/plugins/experimental/mp4/mp4_meta.cc
index 49f1229..3b119e7 100644
--- a/plugins/experimental/mp4/mp4_meta.cc
+++ b/plugins/experimental/mp4/mp4_meta.cc
@@ -1633,7 +1633,10 @@ Mp4Meta::mp4_update_mdhd_duration(Mp4Trak *trak)
mp4_mdhd_atom *mdhd;
mp4_mdhd64_atom mdhd64;
+ memset(&mdhd64, 0, sizeof(mp4_mdhd64_atom));
+
need = TSIOBufferReaderAvail(trak->mdhd_atom.reader);
+
if (need > (int64_t)sizeof(mp4_mdhd64_atom))
need = sizeof(mp4_mdhd64_atom);
@@ -1642,7 +1645,6 @@ Mp4Meta::mp4_update_mdhd_duration(Mp4Trak *trak)
if (this->rs > 0) {
cut = (uint64_t)(this->rs * trak->timescale / 1000);
-
} else {
cut = this->start * trak->timescale / 1000;
}
@@ -1651,7 +1653,6 @@ Mp4Meta::mp4_update_mdhd_duration(Mp4Trak *trak)
duration = mp4_get_32value(mdhd->duration);
duration -= cut;
mp4_reader_set_32value(trak->mdhd_atom.reader, offsetof(mp4_mdhd_atom, duration), duration);
-
} else {
duration = mp4_get_64value(mdhd64.duration);
duration -= cut;
[4/5] trafficserver git commit: TS-3282: Fix NULL check after
dereference CID# 1306623
Posted by so...@apache.org.
TS-3282: Fix NULL check after dereference CID# 1306623
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/10e462e2
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/10e462e2
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/10e462e2
Branch: refs/heads/master
Commit: 10e462e2e3f0d0f8da5526d68efb8c7a6a2e69c9
Parents: 546ec4c
Author: Phil Sorber <so...@apache.org>
Authored: Mon Jun 15 21:16:20 2015 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Mon Jun 15 21:18:46 2015 -0600
----------------------------------------------------------------------
plugins/experimental/mp4/mp4.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/10e462e2/plugins/experimental/mp4/mp4.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/mp4/mp4.cc b/plugins/experimental/mp4/mp4.cc
index 706977e..9988ae0 100644
--- a/plugins/experimental/mp4/mp4.cc
+++ b/plugins/experimental/mp4/mp4.cc
@@ -463,7 +463,7 @@ mp4_parse_meta(Mp4TransformContext *mtc, bool body_complete)
mtc->meta_length = TSIOBufferReaderAvail(mm->out_handle.reader);
}
- if (ret != 0 && mtc->dup_reader) {
+ if (ret != 0) {
TSIOBufferReaderFree(mtc->dup_reader);
mtc->dup_reader = NULL;
}
[3/5] trafficserver git commit: TS-3282: Fix uninitialized pointer
CID# 1306622
Posted by so...@apache.org.
TS-3282: Fix uninitialized pointer CID# 1306622
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/546ec4cd
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/546ec4cd
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/546ec4cd
Branch: refs/heads/master
Commit: 546ec4cd4af02ca09df09ae560e66b78c9101e37
Parents: cb105fe
Author: Phil Sorber <so...@apache.org>
Authored: Mon Jun 15 21:15:24 2015 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Mon Jun 15 21:18:40 2015 -0600
----------------------------------------------------------------------
plugins/experimental/mp4/mp4_meta.h | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/546ec4cd/plugins/experimental/mp4/mp4_meta.h
----------------------------------------------------------------------
diff --git a/plugins/experimental/mp4/mp4_meta.h b/plugins/experimental/mp4/mp4_meta.h
index 3391428..921fe45 100644
--- a/plugins/experimental/mp4/mp4_meta.h
+++ b/plugins/experimental/mp4/mp4_meta.h
@@ -410,6 +410,7 @@ public:
: start(0), cl(0), content_length(0), meta_atom_size(0), meta_avail(0), wait_next(0), need_size(0), rs(0), rate(0),
ftyp_size(0), moov_size(0), start_pos(0), timescale(0), trak_num(0), passed(0), meta_complete(false)
{
+ memset(trak_vec, 0, sizeof(trak_vec));
meta_buffer = TSIOBufferCreate();
meta_reader = TSIOBufferReaderAlloc(meta_buffer);
}
[5/5] trafficserver git commit: TS-3282: Fix NULL check after
dereference CID# 1306624
Posted by so...@apache.org.
TS-3282: Fix NULL check after dereference CID# 1306624
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/5174c55d
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/5174c55d
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/5174c55d
Branch: refs/heads/master
Commit: 5174c55d0091d313faeadb4c1e6ec9d86beeac6e
Parents: 10e462e
Author: Phil Sorber <so...@apache.org>
Authored: Mon Jun 15 21:16:53 2015 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Mon Jun 15 21:18:46 2015 -0600
----------------------------------------------------------------------
plugins/experimental/mp4/mp4_meta.cc | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/5174c55d/plugins/experimental/mp4/mp4_meta.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/mp4/mp4_meta.cc b/plugins/experimental/mp4/mp4_meta.cc
index 3b119e7..51044cd 100644
--- a/plugins/experimental/mp4/mp4_meta.cc
+++ b/plugins/experimental/mp4/mp4_meta.cc
@@ -1173,13 +1173,11 @@ Mp4Meta::mp4_update_ctts_atom(Mp4Trak *trak)
trak->ctts_atom.reader = NULL;
}
- if (trak->ctts_data.reader) {
- TSIOBufferReaderFree(trak->ctts_data.reader);
- TSIOBufferDestroy(trak->ctts_data.buffer);
+ TSIOBufferReaderFree(trak->ctts_data.reader);
+ TSIOBufferDestroy(trak->ctts_data.buffer);
- trak->ctts_data.reader = NULL;
- trak->ctts_data.buffer = NULL;
- }
+ trak->ctts_data.reader = NULL;
+ trak->ctts_data.buffer = NULL;
TSIOBufferReaderFree(readerp);
return 0;
[2/5] trafficserver git commit: TS-3282: Fix uninitialized scalar
CID# 1306621
Posted by so...@apache.org.
TS-3282: Fix uninitialized scalar CID# 1306621
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/cb105fe0
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/cb105fe0
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/cb105fe0
Branch: refs/heads/master
Commit: cb105fe08ad4c299508bf9a3a4378b78ed430c76
Parents: a620d32
Author: Phil Sorber <so...@apache.org>
Authored: Mon Jun 15 21:14:38 2015 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Mon Jun 15 21:18:28 2015 -0600
----------------------------------------------------------------------
plugins/experimental/mp4/mp4_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/cb105fe0/plugins/experimental/mp4/mp4_common.h
----------------------------------------------------------------------
diff --git a/plugins/experimental/mp4/mp4_common.h b/plugins/experimental/mp4/mp4_common.h
index bd0ef94..5977e2b 100644
--- a/plugins/experimental/mp4/mp4_common.h
+++ b/plugins/experimental/mp4/mp4_common.h
@@ -59,7 +59,7 @@ class Mp4TransformContext
{
public:
Mp4TransformContext(float offset, int64_t cl)
- : total(0), tail(0), pos(0), content_length(0), parse_over(false), raw_transform(false)
+ : total(0), tail(0), pos(0), content_length(0), meta_length(0), parse_over(false), raw_transform(false)
{
res_buffer = TSIOBufferCreate();
res_reader = TSIOBufferReaderAlloc(res_buffer);