[jira] [Commented] (HTRACE-142) Details page: Update graph

["Masatake Iwasaki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392227#comment-14392227 ] 

Masatake Iwasaki commented on HTRACE-142:
-----------------------------------------

Thanks for the update, [~abec].

bq. I'd like to simply filter out those parents and fix the collection problem in a separate Jira.

Sure. I agree to fix that in follow-ups.

one more comment..
{code}
  route: function() {
    this.beforeRoute();
    return Backbone.Marionette.AppRouter.prototype.route.apply(this, arguments);
  },
...
    Backbone.Wreqr.radio.channel("graph").vent.on("update:span", function(d) {
      app.root.app.currentView.span.show(
        new app.SpanDetailsView({
          "model": d.span
        }));
    });
...
  "beforeRoute": function() {
    Backbone.Wreqr.radio.channel("graph").vent.off("update:span");
  }
{code}
The part using {{Backbone.Wreqr.radio.channel}} looks like adhoc. Is this a idiom of Marionette?

I think this could be done using view's event handling as in setup.py,
{code}
    var gview = new app.GraphView({
      "collection": this.spansCollection,
      "id": "span-graph"
    });
    
    gview.on("update:span", function(d) {
      app.root.app.currentView.span.show(
        new app.SpanDetailsView({ "model": d.span })
      );
    });

    app.root.app.currentView.content.show(gview);
{code}
and in graph.js,
{code}
    $this.trigger("update:span", {"span": this.collection.findWhere({
      "spanId": spanId
    })});
{code}


> Details page: Update graph
> --------------------------
>
>                 Key: HTRACE-142
>                 URL: https://issues.apache.org/jira/browse/HTRACE-142
>             Project: HTrace
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>             Fix For: 3.2.0
>
>         Attachments: HTRACE-142.001.patch, HTRACE-142.002.patch, HTRACE-142.003.patch, HTRACE-142.004.patch
>
>
> Details page graph general updates. This should have gone in HTRACE-121, but sadly didn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)