You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/03/30 16:11:56 UTC
[GitHub] [incubator-dolphinscheduler] chengshiwen commented on a change in pull request #5153: [1.3.6-prepare][PGSQL] Delete the stopped workflow without deleting t…
chengshiwen commented on a change in pull request #5153:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5153#discussion_r604239655
##########
File path: sql/upgrade/1.3.6_schema/postgresql/dolphinscheduler_ddl.sql
##########
@@ -35,3 +35,8 @@ d//
delimiter ;
SELECT uc_dolphin_T_t_ds_worker_group_A_ip_list();
DROP FUNCTION IF EXISTS uc_dolphin_T_t_ds_worker_group_A_ip_list();
+delimiter ;
+
+-- Add foreign key constraints for t_ds_task_instance --
+ALTER TABLE t_ds_task_instance ADD CONSTRAINT foreign_key_instance_id FOREIGN KEY(process_instance_id) REFERENCES t_ds_process_instance(id) ON DELETE CASCADE;
+
Review comment:
After my comparison, there are still some differences between a and b. I want to sync the `1.3.6_schema` with the dev branch, so the following adjustments will be better 😃
```
-- Add foreign key constraints for t_ds_task_instance --
delimiter ;
ALTER TABLE t_ds_task_instance ADD CONSTRAINT foreign_key_instance_id FOREIGN KEY(process_instance_id) REFERENCES t_ds_process_instance(id) ON DELETE CASCADE;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org