You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Corey Nolet <cj...@gmail.com> on 2015/01/16 05:37:49 UTC
Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info to
user manual and log error when improperly configuring instance.volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/
-----------------------------------------------------------
Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Repository: accumulo
Description
-------
ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
Diffs
-----
docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
Diff: https://reviews.apache.org/r/29959/diff/
Testing
-------
Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
Thanks,
Corey Nolet
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Sean Busbey <se...@manvsbeard.com>.
> On Jan. 17, 2015, 1:08 a.m., Sean Busbey wrote:
> > docs/src/main/latex/accumulo_user_manual/chapters/administration.tex, line 584
> > <https://reviews.apache.org/r/29959/diff/3/?file=823376#file823376line584>
> >
> > nit: you should say what an operator should expect to see from this command when it's successful (nothing, IIRC) and maybe what it says if it fails.
>
> Corey Nolet wrote:
> I was going to add a log statement so that the user could get some feedback but then I came across line 294 in the Initialize class. Were you at least able to see the "Added volume <volume>" log statement? Were you looking for something more descriptive?
When I ran through the instructions (which was back on 1.6.0), nothing was output to the console. I didn't go digging into logs though.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68522
-----------------------------------------------------------
On Jan. 19, 2015, 6 p.m., Corey Nolet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2015, 6 p.m.)
>
>
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
>
>
> Diffs
> -----
>
> docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
>
> Diff: https://reviews.apache.org/r/29959/diff/
>
>
> Testing
> -------
>
> Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
>
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
>
>
> Thanks,
>
> Corey Nolet
>
>
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Corey Nolet <cj...@gmail.com>.
> On Jan. 17, 2015, 1:08 a.m., Sean Busbey wrote:
> > docs/src/main/latex/accumulo_user_manual/chapters/administration.tex, line 584
> > <https://reviews.apache.org/r/29959/diff/3/?file=823376#file823376line584>
> >
> > nit: you should say what an operator should expect to see from this command when it's successful (nothing, IIRC) and maybe what it says if it fails.
I was going to add a log statement so that the user could get some feedback but then I came across line 294 in the Initialize class. Were you at least able to see the "Added volume <volume>" log statement? Were you looking for something more descriptive?
- Corey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68522
-----------------------------------------------------------
On Jan. 16, 2015, 5:06 a.m., Corey Nolet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 5:06 a.m.)
>
>
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
>
>
> Diffs
> -----
>
> docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
>
> Diff: https://reviews.apache.org/r/29959/diff/
>
>
> Testing
> -------
>
> Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
>
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
>
>
> Thanks,
>
> Corey Nolet
>
>
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68522
-----------------------------------------------------------
Ship it!
docs/src/main/latex/accumulo_user_manual/chapters/administration.tex
<https://reviews.apache.org/r/29959/#comment112828>
nit: you should say what an operator should expect to see from this command when it's successful (nothing, IIRC) and maybe what it says if it fails.
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
<https://reviews.apache.org/r/29959/#comment112827>
please don't remove the braces for the if statement.
- Sean Busbey
On Jan. 16, 2015, 5:06 a.m., Corey Nolet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 5:06 a.m.)
>
>
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
>
>
> Diffs
> -----
>
> docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
>
> Diff: https://reviews.apache.org/r/29959/diff/
>
>
> Testing
> -------
>
> Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
>
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
>
>
> Thanks,
>
> Corey Nolet
>
>
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 3:10 p.m.)
Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Changes
-------
Add JIRA link
Bugs: ACCUMULO-2793
https://issues.apache.org/jira/browse/ACCUMULO-2793
Repository: accumulo
Description
-------
ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
Diffs
-----
docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
Diff: https://reviews.apache.org/r/29959/diff/
Testing
-------
Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
Thanks,
Corey Nolet
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/
-----------------------------------------------------------
(Updated Jan. 19, 2015, 6 p.m.)
Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Repository: accumulo
Description
-------
ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
Diffs (updated)
-----
docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
Diff: https://reviews.apache.org/r/29959/diff/
Testing
-------
Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
Thanks,
Corey Nolet
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by ke...@deenlo.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68436
-----------------------------------------------------------
Ship it!
Ship It!
- kturner
On Jan. 16, 2015, 5:06 a.m., Corey Nolet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 5:06 a.m.)
>
>
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
>
>
> Diffs
> -----
>
> docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
>
> Diff: https://reviews.apache.org/r/29959/diff/
>
>
> Testing
> -------
>
> Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
>
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
>
>
> Thanks,
>
> Corey Nolet
>
>
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 5:06 a.m.)
Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Repository: accumulo
Description
-------
ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
Diffs (updated)
-----
docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
Diff: https://reviews.apache.org/r/29959/diff/
Testing
-------
Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
Thanks,
Corey Nolet
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 5:03 a.m.)
Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Repository: accumulo
Description
-------
ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
Diffs (updated)
-----
docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
Diff: https://reviews.apache.org/r/29959/diff/
Testing
-------
Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
Thanks,
Corey Nolet
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68408
-----------------------------------------------------------
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
<https://reviews.apache.org/r/29959/#comment112605>
Just noticed this. We should certainly have the conversation to standardize on this. I don't mind doing what everyone's been doing, I just need to know what that is.
- Corey Nolet
On Jan. 16, 2015, 4:37 a.m., Corey Nolet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 4:37 a.m.)
>
>
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
>
>
> Diffs
> -----
>
> docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
>
> Diff: https://reviews.apache.org/r/29959/diff/
>
>
> Testing
> -------
>
> Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
>
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
>
>
> Thanks,
>
> Corey Nolet
>
>
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Corey Nolet <cj...@gmail.com>.
> On Jan. 16, 2015, 4:57 a.m., Josh Elser wrote:
> > server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java, line 39
> > <https://reviews.apache.org/r/29959/diff/1/?file=823371#file823371line39>
> >
> > Unnecessary change?
You are right- originally I had the error log in this class but then I moved it. I'll remove this.
> On Jan. 16, 2015, 4:57 a.m., Josh Elser wrote:
> > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java, line 506
> > <https://reviews.apache.org/r/29959/diff/1/?file=823372#file823372line506>
> >
> > Unnecessary change?
This happened when I ran the formatter.
- Corey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68407
-----------------------------------------------------------
On Jan. 16, 2015, 4:37 a.m., Corey Nolet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 4:37 a.m.)
>
>
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
>
>
> Diffs
> -----
>
> docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
>
> Diff: https://reviews.apache.org/r/29959/diff/
>
>
> Testing
> -------
>
> Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
>
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
>
>
> Thanks,
>
> Corey Nolet
>
>
Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration
info
to user manual and log error when improperly configuring instance.volumes.
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68407
-----------------------------------------------------------
Ship it!
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java
<https://reviews.apache.org/r/29959/#comment112603>
Unnecessary change?
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
<https://reviews.apache.org/r/29959/#comment112604>
Unnecessary change?
- Josh Elser
On Jan. 16, 2015, 4:37 a.m., Corey Nolet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 4:37 a.m.)
>
>
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as an error message when a replaced instance appears in instance.volumes
>
>
> Diffs
> -----
>
> docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797
>
> Diff: https://reviews.apache.org/r/29959/diff/
>
>
> Testing
> -------
>
> Built the manual and found that the page numbers aren't aligning with the table of contents. Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's been around for awhile.
>
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is called and a replaced volume appears in instance.volumes. Also verified that the error does not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not appear in instance.volumes
>
>
> Thanks,
>
> Corey Nolet
>
>