You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/12/16 09:43:30 UTC
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #2140: [SCB-2164]InstanceCacheCheckTask only print necessary message to avoi…
liubao68 opened a new pull request #2140:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2140
…d information leak
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] wujimin merged pull request #2140: [SCB-2164]InstanceCacheCheckTask only print necessary message to avoi…
Posted by GitBox <gi...@apache.org>.
wujimin merged pull request #2140:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-io commented on pull request #2140: [SCB-2164]InstanceCacheCheckTask only print necessary message to avoi…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2140:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2140#issuecomment-746028876
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140?src=pr&el=h1) Report
> Merging [#2140](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140?src=pr&el=desc) (93bdf2f) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/4d613ee7e142116531b9bec31ae15c364980d01d?el=desc) (4d613ee) will **decrease** coverage by `0.03%`.
> The diff coverage is `69.23%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2140 +/- ##
============================================
- Coverage 80.77% 80.73% -0.04%
Complexity 1337 1337
============================================
Files 1462 1462
Lines 40081 40093 +12
Branches 3399 3399
============================================
- Hits 32374 32368 -6
- Misses 6243 6259 +16
- Partials 1464 1466 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...istry/diagnosis/instance/InstanceCacheChecker.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2RpYWdub3Npcy9pbnN0YW5jZS9JbnN0YW5jZUNhY2hlQ2hlY2tlci5qYXZh) | `90.00% <33.33%> (-5.32%)` | `0.00 <0.00> (ø)` | |
| [...mb/registry/api/registry/MicroserviceInstance.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvYXBpL3JlZ2lzdHJ5L01pY3Jvc2VydmljZUluc3RhbmNlLmphdmE=) | `97.26% <100.00%> (+0.24%)` | `0.00 <0.00> (ø)` | |
| [...try/diagnosis/instance/InstanceCacheCheckTask.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2RpYWdub3Npcy9pbnN0YW5jZS9JbnN0YW5jZUNhY2hlQ2hlY2tUYXNrLmphdmE=) | `90.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/servicecomb/config/kie/client/KieClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140/diff?src=pr&el=tree#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWtpZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ2xpZW50LmphdmE=) | `72.61% <0.00%> (-5.96%)` | `0.00% <0.00%> (ø%)` | |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `75.70% <0.00%> (-1.87%)` | `0.00% <0.00%> (ø%)` | |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `69.32% <0.00%> (-1.17%)` | `0.00% <0.00%> (ø%)` | |
| [.../servicecomb/config/client/ConfigCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140/diff?src=pr&el=tree#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvY2xpZW50L0NvbmZpZ0NlbnRlckNsaWVudC5qYXZh) | `52.11% <0.00%> (-0.43%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140?src=pr&el=footer). Last update [4d613ee...93bdf2f](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2140?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org