You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/31 16:19:39 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7858: [fix]
Isolate and improve performance on tagging system
codecov-io commented on issue #7858: [fix] Isolate and improve performance on tagging system
URL: https://github.com/apache/incubator-superset/pull/7858#issuecomment-516919983
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7858?src=pr&el=h1) Report
> Merging [#7858](https://codecov.io/gh/apache/incubator-superset/pull/7858?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9b7261f101f4acbdd2721a202bedfc231b529816?src=pr&el=desc) will **decrease** coverage by `0.48%`.
> The diff coverage is `13.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7858?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7858 +/- ##
==========================================
- Coverage 65.96% 65.47% -0.49%
==========================================
Files 468 469 +1
Lines 22308 22381 +73
Branches 2432 2432
==========================================
- Hits 14715 14654 -61
- Misses 7472 7606 +134
Partials 121 121
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7858?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7858/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.12% <20%> (-1.9%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/7858/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `37.33% <42.85%> (+0.17%)` | :arrow_up: |
| [superset/common/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/7858/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3RhZ3MucHk=) | `9.23% <9.23%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/7858/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `34.88% <0%> (-58.14%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/7858/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `59.4% <0%> (-30.7%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7858/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71% <0%> (-0.22%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7858?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7858?src=pr&el=footer). Last update [9b7261f...ed8bc9f](https://codecov.io/gh/apache/incubator-superset/pull/7858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org