You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/29 04:12:13 UTC
[GitHub] [airflow] vikramkoka opened a new pull request #13968: Updated taskflow api doc to show dependency with sensor
vikramkoka opened a new pull request #13968:
URL: https://github.com/apache/airflow/pull/13968
Updated the taskflow api tutorial document to show how to setup a
dependency to a python-based decorated task from a classic
FileSensor task.
This doc addition done in response to question asked in Airflow slack.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13968: Updated taskflow api doc to show dependency with sensor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13968:
URL: https://github.com/apache/airflow/pull/13968#issuecomment-769975084
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13968: Updated taskflow api doc to show dependency with sensor
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13968:
URL: https://github.com/apache/airflow/pull/13968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13968: Updated taskflow api doc to show dependency with sensor
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13968:
URL: https://github.com/apache/airflow/pull/13968#discussion_r567012215
##########
File path: docs/apache-airflow/tutorial_taskflow_api.rst
##########
@@ -177,6 +177,40 @@ is automatically set to true.
Note, If you manually set the ``multiple_outputs`` parameter the inference is disabled and
the parameter value is used.
+Adding dependencies to decorated tasks from regular tasks
+---------------------------------------------------------
+The above tutorial shows how to create dependencies between python-based tasks. However, it is
+quite possible while writing a DAG to have some pre-existing tasks such as BashOperator or FileSensor
Review comment:
This will make it easy for users to go to the Operator / Sensor definition if they are not already aware about it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13968: Updated taskflow api doc to show dependency with sensor
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13968:
URL: https://github.com/apache/airflow/pull/13968#discussion_r567011891
##########
File path: docs/apache-airflow/tutorial_taskflow_api.rst
##########
@@ -177,6 +177,40 @@ is automatically set to true.
Note, If you manually set the ``multiple_outputs`` parameter the inference is disabled and
the parameter value is used.
+Adding dependencies to decorated tasks from regular tasks
+---------------------------------------------------------
+The above tutorial shows how to create dependencies between python-based tasks. However, it is
+quite possible while writing a DAG to have some pre-existing tasks such as BashOperator or FileSensor
Review comment:
```suggestion
quite possible while writing a DAG to have some pre-existing tasks such as :class:`~airflow.operators.bash.BashOperator` or :class:`~airflow.sensors.filesystem.FileSensor`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org