You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/30 10:54:40 UTC
[GitHub] [flink] yanghua opened a new pull request #10972: [FLINK-15810] Add
more description for FlinkKafkaProducerMigrationOperatorTest
yanghua opened a new pull request #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972
## What is the purpose of the change
*This pull request adds more description for FlinkKafkaProducerMigrationOperatorTest*
## Brief change log
- *Add more description for FlinkKafkaProducerMigrationOperatorTest*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10972: [FLINK-15810] Add more
description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580198900
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 08d2560037a55c15cd776c6f6325adccda598af1 (Thu Jan 30 10:56:47 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15810).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10972: [FLINK-15810]
Add more description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580212572
<!--
Meta data
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146739310 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
-->
## CI report:
* 08d2560037a55c15cd776c6f6325adccda598af1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146739310) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10972: [FLINK-15810]
Add more description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580212572
<!--
Meta data
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/146739310 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146923584 TriggerType:PUSH TriggerID:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a
Hash:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4728 TriggerType:PUSH TriggerID:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a
-->
## CI report:
* 08d2560037a55c15cd776c6f6325adccda598af1 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/146739310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676)
* 3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146923584) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4728)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10972: [FLINK-15810]
Add more description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580212572
<!--
Meta data
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/146739310 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146923584 TriggerType:PUSH TriggerID:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a
Hash:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4728 TriggerType:PUSH TriggerID:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a
-->
## CI report:
* 08d2560037a55c15cd776c6f6325adccda598af1 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/146739310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676)
* 3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146923584) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4728)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10972: [FLINK-15810] Add more
description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580212572
<!--
Meta data
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
-->
## CI report:
* 08d2560037a55c15cd776c6f6325adccda598af1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10972: [FLINK-15810]
Add more description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580212572
<!--
Meta data
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146739310 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
-->
## CI report:
* 08d2560037a55c15cd776c6f6325adccda598af1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146739310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10972: [FLINK-15810]
Add more description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580212572
<!--
Meta data
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/146739310 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146923584 TriggerType:PUSH TriggerID:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a
Hash:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4728 TriggerType:PUSH TriggerID:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a
-->
## CI report:
* 08d2560037a55c15cd776c6f6325adccda598af1 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/146739310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676)
* 3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146923584) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4728)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on a change in pull request #10972:
[FLINK-15810] Add more description for
FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#discussion_r373476083
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java
##########
@@ -28,6 +28,12 @@
/**
* Migration test from FlinkKafkaProducer011 operator.
+ * This test depends on the resource generated by {@link FlinkKafkaProducer011MigrationTest#writeSnapshot()}.
+ *
+ * <p>Warning: We need to rename the generated resource based on the file naming pattern specified by
+ * the {@link #getOperatorSnapshotPath(MigrationVersion)} method then
+ * copy the resource to the path also specified by the {@link #getOperatorSnapshotPath(MigrationVersion)} method.
+ * </p>
Review comment:
Thanks for your review. I have removed `</p>` tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on issue #10972: [FLINK-15810] Add more
description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580558540
cc @aljoscha
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10972:
[FLINK-15810] Add more description for
FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#discussion_r373423537
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java
##########
@@ -28,6 +28,12 @@
/**
* Migration test from FlinkKafkaProducer011 operator.
+ * This test depends on the resource generated by {@link FlinkKafkaProducer011MigrationTest#writeSnapshot()}.
+ *
+ * <p>Warning: We need to rename the generated resource based on the file naming pattern specified by
+ * the {@link #getOperatorSnapshotPath(MigrationVersion)} method then
+ * copy the resource to the path also specified by the {@link #getOperatorSnapshotPath(MigrationVersion)} method.
+ * </p>
Review comment:
Javadoc shouldn't have a closing `</p>` tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10972: [FLINK-15810]
Add more description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#issuecomment-580212572
<!--
Meta data
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146739310 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:08d2560037a55c15cd776c6f6325adccda598af1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676 TriggerType:PUSH TriggerID:08d2560037a55c15cd776c6f6325adccda598af1
Hash:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3cb668c5612ca1bd6bec7fa5fe3b909ed674509a
-->
## CI report:
* 08d2560037a55c15cd776c6f6325adccda598af1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146739310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4676)
* 3cb668c5612ca1bd6bec7fa5fe3b909ed674509a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha merged pull request #10972: [FLINK-15810] Add more
description for FlinkKafkaProducerMigrationOperatorTest
Posted by GitBox <gi...@apache.org>.
aljoscha merged pull request #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services