You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Xiangrui Meng (JIRA)" <ji...@apache.org> on 2015/05/06 02:06:00 UTC

[jira] [Commented] (SPARK-5283) ML sharedParams should be private

    [ https://issues.apache.org/jira/browse/SPARK-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529599#comment-14529599 ] 

Xiangrui Meng commented on SPARK-5283:
--------------------------------------

Fixed as part of https://github.com/apache/spark/pull/5740.

> ML sharedParams should be private
> ---------------------------------
>
>                 Key: SPARK-5283
>                 URL: https://issues.apache.org/jira/browse/SPARK-5283
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 1.2.0
>            Reporter: Joseph K. Bradley
>            Assignee: Joseph K. Bradley
>             Fix For: 1.4.0
>
>
> The many shared Params implemented in sharedParams.scala should be made public.
> Cons:
> * Shared params discourage developers from documenting parameters and from making algorithm-specific checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org