You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/04/27 22:14:31 UTC
Review Request 58818: Ensured DEBUG container shares MESOS_SANDBOX
with its parent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Bugs: MESOS-7355
https://issues.apache.org/jira/browse/MESOS-7355
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
Diff: https://reviews.apache.org/r/58818/diff/1/
Testing
-------
`make check` on Mac OS and Fedora 24
Thanks,
Alexander Rukletsov
Re: Review Request 58818: Ensured DEBUG container shares
MESOS_SANDBOX with its parent.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/#review173269
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 27, 2017, 10:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58818/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 10:14 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7355
> https://issues.apache.org/jira/browse/MESOS-7355
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58818/diff/1/
>
>
> Testing
> -------
>
> `make check` on Mac OS and Fedora 24
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58818: Ensured DEBUG container shares
MESOS_SANDBOX with its parent.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/#review173662
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58818/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7355
> https://issues.apache.org/jira/browse/MESOS-7355
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58818/diff/2/
>
>
> Testing
> -------
>
> `make check` on Mac OS and Fedora 24
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58818: Ensured DEBUG container shares
MESOS_SANDBOX with its parent.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/
-----------------------------------------------------------
(Updated May 9, 2017, 2:31 p.m.)
Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Rebased. NNTR.
Bugs: MESOS-7355
https://issues.apache.org/jira/browse/MESOS-7355
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4
Diff: https://reviews.apache.org/r/58818/diff/4/
Changes: https://reviews.apache.org/r/58818/diff/3-4/
Testing
-------
`make check` on Mac OS and Fedora 24
Thanks,
Alexander Rukletsov
Re: Review Request 58818: Ensured DEBUG container shares
MESOS_SANDBOX with its parent.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/
-----------------------------------------------------------
(Updated May 3, 2017, 4:45 p.m.)
Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Rebased, NNTR.
Bugs: MESOS-7355
https://issues.apache.org/jira/browse/MESOS-7355
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
Diff: https://reviews.apache.org/r/58818/diff/3/
Changes: https://reviews.apache.org/r/58818/diff/2-3/
Testing
-------
`make check` on Mac OS and Fedora 24
Thanks,
Alexander Rukletsov
Re: Review Request 58818: Ensured DEBUG container shares
MESOS_SANDBOX with its parent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/#review173376
-----------------------------------------------------------
Ship it!
Nice test.
- Vinod Kone
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58818/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7355
> https://issues.apache.org/jira/browse/MESOS-7355
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58818/diff/2/
>
>
> Testing
> -------
>
> `make check` on Mac OS and Fedora 24
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58818: Ensured DEBUG container shares
MESOS_SANDBOX with its parent.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/
-----------------------------------------------------------
(Updated April 28, 2017, 4:14 p.m.)
Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-7355
https://issues.apache.org/jira/browse/MESOS-7355
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
Diff: https://reviews.apache.org/r/58818/diff/2/
Changes: https://reviews.apache.org/r/58818/diff/1-2/
Testing
-------
`make check` on Mac OS and Fedora 24
Thanks,
Alexander Rukletsov