You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2020/10/01 21:27:44 UTC
Review Request 72924: RANGER-3020: Normalize naming and processing of
config parameters for chained plugin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72924/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
Bugs: RANGER-3020
https://issues.apache.org/jira/browse/RANGER-3020
Repository: ranger
Description
-------
Chained plugin config needs to copy selected configuration parameters from root plugin's config and rename them to set up for proper creation and operation of chained plugin.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java 81cebf489
Diff: https://reviews.apache.org/r/72924/diff/1/
Testing
-------
Passed all unit tests
Thanks,
Abhay Kulkarni
Re: Review Request 72924: RANGER-3020: Normalize naming and
processing of config parameters for chained plugin
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
> On Oct. 2, 2020, 3:16 p.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java
> > Lines 92 (patched)
> > <https://reviews.apache.org/r/72924/diff/1/?file=2240241#file2240241line101>
> >
> > Consider handling this case in copyProperties() itself, in else clause at #66.
Copying of chained.services configurations needs to be done after all other copying is done, otherwise, it may cause infinite loop of creating chained plugins (such as hdfs->hive->hive->...).
- Abhay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72924/#review221990
-----------------------------------------------------------
On Oct. 1, 2020, 9:27 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72924/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2020, 9:27 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3020
> https://issues.apache.org/jira/browse/RANGER-3020
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Chained plugin config needs to copy selected configuration parameters from root plugin's config and rename them to set up for proper creation and operation of chained plugin.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java 81cebf489
>
>
> Diff: https://reviews.apache.org/r/72924/diff/1/
>
>
> Testing
> -------
>
> Passed all unit tests
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 72924: RANGER-3020: Normalize naming and
processing of config parameters for chained plugin
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72924/#review221990
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java
Lines 92 (patched)
<https://reviews.apache.org/r/72924/#comment311063>
Consider handling this case in copyProperties() itself, in else clause at #66.
- Madhan Neethiraj
On Oct. 1, 2020, 9:27 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72924/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2020, 9:27 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3020
> https://issues.apache.org/jira/browse/RANGER-3020
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Chained plugin config needs to copy selected configuration parameters from root plugin's config and rename them to set up for proper creation and operation of chained plugin.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java 81cebf489
>
>
> Diff: https://reviews.apache.org/r/72924/diff/1/
>
>
> Testing
> -------
>
> Passed all unit tests
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 72924: RANGER-3020: Normalize naming and
processing of config parameters for chained plugin
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72924/#review221989
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Oct. 1, 2020, 9:27 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72924/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2020, 9:27 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3020
> https://issues.apache.org/jira/browse/RANGER-3020
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Chained plugin config needs to copy selected configuration parameters from root plugin's config and rename them to set up for proper creation and operation of chained plugin.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java 81cebf489
>
>
> Diff: https://reviews.apache.org/r/72924/diff/1/
>
>
> Testing
> -------
>
> Passed all unit tests
>
>
> Thanks,
>
> Abhay Kulkarni
>
>