You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 18:26:06 UTC

[GitHub] [flink] pnowojski commented on pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers

pnowojski commented on pull request #13741:
URL: https://github.com/apache/flink/pull/13741#issuecomment-716740229


   > I don't see the benefit to add alignment timeout to CheckpointOptions. I'd rather have it on task level pass to Aligner.
   
   if not `alignmentTimeout`, I would still need to add some flag like `isTimeoutable` or `requiresAnnouncement` to the `CheckpointOptions`, to distinguish in the `DataType#getDataType` between:
   - aligned non-timeoutable checkpoint/savepoint
   - aligned timeoutable checkpoint
   - unaligned checkpoint
   
   if we already need this bit of information, why not use it pass the timeout itself?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org